Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #79190

Closed
wants to merge 30 commits into from

Commits on Nov 11, 2020

  1. Add a sane error for rust-call functions not taking tuples during typ…

    …e checking, and associated UI tests
    CraftSpider committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    91eabf5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf04b04 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    1e9d5c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2020

  1. Add column number support to Backtrace

    Backtrace frames might include column numbers.
    Print them if they are included.
    est31 committed Nov 15, 2020
    Configuration menu
    Copy the full SHA
    43bfbb1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    2b7ffec View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2020

  1. Use span_suggestion_verbose instead of span_suggestion for fn w…

    …ith qualifiers inside an `extern "C"` block
    ThePuzzlemaker committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    92aa0e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b8ed466 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c825c74 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    42e45f8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e8426a6 View commit details
    Browse the repository at this point in the history
  6. Fix tests

    Anthuang committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    2c22c05 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    614a748 View commit details
    Browse the repository at this point in the history
  8. Move capture lowering from THIR to MIR

    This allows us to:
    - Handle precise Places captured by a closure directly in MIR. Handling
    captures in MIR is easier since we can rely on/ tweak PlaceBuilder to
    generate `mir::Place`s that resemble how we store captures (`hir::Place`).
    - Allows us to handle `let _ = x` case when feature `capture_disjoint_fields`
    is enabled directly in MIR. This is required to be done in MIR since
    patterns are desugared in MIR.
    arora-aman committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    7faebe5 View commit details
    Browse the repository at this point in the history
  9. Remove THIR::ExprKind::SelfRef

    ExprKind::SelfRef was used to express accessing `self` in
    the desugared Closure/Generator struct when lowering captures in THIR.
    
    Since we handle captures in MIR now, we don't need `ExprKind::Self`.
    arora-aman committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    9f70e78 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Allow using download-ci-llvm from directories other than the root

    Previously, bootstrap.py would attempt to find the LLVM commit from
    `src/llvm-project`. However, it assumed it was always being run from the
    top-level directory, which isn't always the case.
    
    Before:
    
    ```
    downloading https://ci-artifacts.rust-lang.org/rustc-builds//rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
    
    curl: (22) The requested URL returned error: 404
    failed to run: curl -# -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmppyh4w8 https://ci-artifacts.rust-lang.org/rustc-builds//rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
    Build completed unsuccessfully in 0:00:02
    ```
    
    After:
    
    ```
    downloading https://ci-artifacts.rust-lang.org/rustc-builds/430feb24a46993e5073c1bb1b39da190d83fa2bf/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
     ###################################################################################################################################################################### 100.0%
    extracting /home/joshua/rustc/src/bootstrap/build/cache/llvm-430feb24a46993e5073c1bb1b39da190d83fa2bf-False/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
    ```
    jyn514 committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    5163912 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    efcbf1b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    85bc953 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2098ade View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3527964 View commit details
    Browse the repository at this point in the history
  6. review comment

    estebank committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c12e77b View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Rollup merge of rust-lang#77675 - Anthuang:tidy-line-length, r=Mark-S…

    …imulacrum
    
    Tidy should not check line lengths in tests
    
    Tidy will not check line lengths in tests even without the `// ignore-tidy-linelength` annotations. This PR also removes all the annotations which are now unnecessary.
    
    Closes: rust-lang#77548
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    956135c View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#78961 - CraftSpider:22565, r=oli-obk

    Make bad "rust-call" arguments no longer ICE
    
    The simplest of bad rust-call definitions will no longer cause an ICE. There is a FIXME added for future work, as I wanted to get this easy fix in before trying to either add a hack or mess with the whole obligation system
    
    fixes rust-lang#22565
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    517a33a View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#79002 - est31:backtrace_colno, r=dtolnay

    Add column number support to Backtrace
    
    Backtrace frames might include column numbers.
    Print them if they are included.
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    424fdd8 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#79082 - ThePuzzlemaker:issue-78941-fix, r=e…

    …stebank
    
    Improve the diagnostic for when an `fn` contains qualifiers inside an `extern` block.
    
    This mitigates rust-lang#78941. As suggested by ``@estebank,`` `span_suggestion` was replaced with `span_suggestion_verbose` for this specific diagnostic.
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    60a6e17 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#79101 - tmiasko:lower-func-type, r=jonas-sc…

    …hievink
    
    Don't special case constant operands when lowering intrinsics
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    773ca5e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#79110 - estebank:issue-58964, r=oli-obk

    Remove redundant notes in E0275
    
    Fix rust-lang#58964.
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    42ab0d3 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#79147 - camelid:mir-gitattributes, r=oli-obk

    Highlight MIR as Rust on GitHub
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    a35eb22 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#79149 - sexxi-goose:upvar_ref, r=nikomatsakis

    Move capture lowering from THIR to MIR
    
    This allows us to:
    - Handle precise Places captured by a closure directly in MIR. Handling
      captures in MIR is easier since we can rely on/ tweak PlaceBuilder to
      generate `mir::Place`s that resemble how we store captures (`hir::Place`).
    
    - Handle `let _ = x` case when feature `capture_disjoint_fields`
      is enabled directly in MIR. This is required to be done in MIR since
      patterns are desugared in MIR.
    
    Closes: rust-lang/project-rfc-2229#25
    
    r? ``@nikomatsakis``
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    843720b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#79156 - jyn514:relative-llvm, r=Mark-Simula…

    …crum
    
    Allow using `download-ci-llvm` from directories other than the root
    
    Previously, bootstrap.py would attempt to find the LLVM commit from
    `src/llvm-project`. However, it assumed it was always being run from the
    top-level directory, which isn't always the case.
    
    Before:
    
    ```
    downloading https://ci-artifacts.rust-lang.org/rustc-builds//rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
    
    curl: (22) The requested URL returned error: 404
    failed to run: curl -# -y 30 -Y 10 --connect-timeout 30 --retry 3 -Sf -o /tmp/tmppyh4w8 https://ci-artifacts.rust-lang.org/rustc-builds//rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
    Build completed unsuccessfully in 0:00:02
    ```
    
    After:
    
    ```
    downloading https://ci-artifacts.rust-lang.org/rustc-builds/430feb24a46993e5073c1bb1b39da190d83fa2bf/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
     ###################################################################################################################################################################### 100.0%
    extracting /home/joshua/rustc/src/bootstrap/build/cache/llvm-430feb24a46993e5073c1bb1b39da190d83fa2bf-False/rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
    ```
    
    r? ``@Mark-Simulacrum``
    cc ``@pnkfelix``
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    406281b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#79164 - varkor:unbraced-single-segment-cons…

    …t-arguments, r=petrochenkov
    
    Permit standalone generic parameters as const generic arguments in macros
    
    Fixes rust-lang#79127.
    
    r? ``@petrochenkov``
    Dylan-DPC committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    37e64af View commit details
    Browse the repository at this point in the history