Wrong suggestion: remove the qualifiers: fn

[DutchGhost]

When declaring extern functions with any qualifier (async, const, unsafe) like down below, rustc incorrectly suggests to remove the qualifier fn

extern "C" {
    async fn calleth();
}

The error message

error: functions in `extern` blocks cannot have qualifiers
 --> src/lib.rs:2:14
  |
1 | extern "C" {
  | ---------- in this `extern` block
2 |     async fn calleth();
  |     ---------^^^^^^^
  |     |
  |     help: remove the qualifiers: `fn`

error: aborting due to previous error

error: could not compile `playground`

To learn more, run the command again with --verbose.

[estebank]

It would be clearer if this wasn't an inline suggestion. The suggestion is trying to communicate to write

extern "C" {
    fn calleth();
}

This can be easily be fixed with a change from span_suggestion to span_suggestion_verbose.

[ThePuzzlemaker]

@rustbot claim

[ThePuzzlemaker]

When using span_suggestion_verbose, the following is emitted:

error: functions in `extern` blocks cannot have qualifiers
 --> <anon>:2:11
  |
1 | extern "C" {
  | ---------- in this `extern` block
2 |     async fn calleth();
  |              ^^^^^^^
  |
help: remove the qualifiers
  |
2 |     fn calleth();
  |     ^^

error: aborting due to previous error

Is this what is desired?

[estebank]

Is this what is desired?

Yes.

[ThePuzzlemaker]

Fixed by #79200, a rollup containing #79082

[ThePuzzlemaker]

@DutchGhost ^

[JohnTitor]

Closing as fixed.

@ThePuzzlemaker You could close an issue by writing Fixes #<issue-number> in the OP.