Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch a bad placeholder type error for statics in externs #83734

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

JohnTitor
Copy link
Member

Fixes #83621

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2021
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 5, 2021

📌 Commit b5782ba has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83370 (Add `x.py setup tools` which enables `download-rustc` by default)
 - rust-lang#83489 (Properly suggest deref in else block)
 - rust-lang#83734 (Catch a bad placeholder type error for statics in `extern`s)
 - rust-lang#83814 (expand: Do not ICE when a legacy AST-based macro attribute produces and empty expression)
 - rust-lang#83835 (rustdoc: sort search index items for compression)
 - rust-lang#83849 (rustdoc: Cleanup handling of associated items for intra-doc links)
 - rust-lang#83881 (:arrow_up: rust-analyzer)
 - rust-lang#83885 (Document compiler/ with -Aprivate-intra-doc-links)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 76be7e2 into rust-lang:master Apr 6, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 6, 2021
@JohnTitor JohnTitor deleted the issue-83621 branch April 6, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: compiler/rustc_lint/src/types.rs:1132:32: unexpected type in foreign function: [type error]
5 participants