Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #84473

Closed
wants to merge 36 commits into from

Commits on Mar 25, 2021

  1. Configuration menu
    Copy the full SHA
    30fc601 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    321aace View commit details
    Browse the repository at this point in the history
  3. Updating test stderr files

    sunjay committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    7faaf39 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    789186d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2acd8eb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3e34eb8 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2021

  1. Configuration menu
    Copy the full SHA
    539242a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eea27b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. rustdoc: use details tag for trait implementors

    This switches from JS-generated toggles to using the HTML <details> tag
    for expanding and collapsing entries in the "Implementors" section.
    jsha committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    569096c View commit details
    Browse the repository at this point in the history
  2. ⬆️ rust-analyzer

    lnicola committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    e85f19b View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Configuration menu
    Copy the full SHA
    f505d61 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cabbd0 View commit details
    Browse the repository at this point in the history
  3. Clean up .gitignore

    CDirkx committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    3794fc9 View commit details
    Browse the repository at this point in the history
  4. Remove "Version control"

    CDirkx committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c0d05d2 View commit details
    Browse the repository at this point in the history
  5. doc/platform-support: clarify UEFI support

    Add missing information on what standard-library features are supported
    by the UEFI targets.
    
    All current UEFI targets (which is i686 and x86_64) only support no_std
    cross-compilations. `std` support has not been worked on and is unlikely
    to emerge anytime soon, due to the much restricted environment that UEFI
    provides.
    dvdhrm committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    bfbf4ce View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a03cba3 View commit details
    Browse the repository at this point in the history
  7. Get rid of "[+] show undocumented items" toggle on numeric From impls

    On most From implementations, the docstring is attached to the
    function. This is also how people have been [recommended] to do it.
    
    Screenshots:
    
    * [before](https://user-images.githubusercontent.com/1593513/115767662-323c5480-a35e-11eb-9918-98aba83e9183.png)
    * [after](https://user-images.githubusercontent.com/1593513/115767675-35374500-a35e-11eb-964f-c28eeb6c807a.png)
    
    [recommended]: rust-lang#51430 (comment)
    notriddle committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c247055 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a07bf2e View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Configuration menu
    Copy the full SHA
    e1d9b3c View commit details
    Browse the repository at this point in the history
  2. Use ItemType in cache

    jyn514 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    3170536 View commit details
    Browse the repository at this point in the history
  3. Remove TypeKind

    jyn514 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2df886d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    26f2705 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a344282 View commit details
    Browse the repository at this point in the history
  6. Fix macro bug in impl From<DefKind> for ItemType

    This was missed a while ago when support for proc-macro attributes was
    first added.
    jyn514 committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6c066ab View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#83004 - sunjay:field-never-read-issue-81658…

    …, r=pnkfelix
    
    Improve diagnostic for when field is never read
    
    Related to (but does not close) rust-lang#81658
    
    This completes the first step of ``@pnkfelix's`` [mentoring instructions](rust-lang#81658 (comment)) but does not actually improve the diagnostics (yet!). The two tests are heavily reduced versions of code from the original bug report.
    
    I've confirmed that the reduced `field-used-in-ffi` test [fails on nightly](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=f0862c89ddca028c55c20a5ed05e679a) but [passes on stable](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=f0862c89ddca028c55c20a5ed05e679a). This confirms that the regression is reproduced correctly. The `drop-only-field` test is a case that ``@pnkfelix`` mentioned in his mentoring instructions. It is not a regression, but will come in handy when we make the diagnostic smarter by looking at whether the field type implements `Drop`.
    
    Per the [rustc-dev-guide](https://rustc-dev-guide.rust-lang.org/tests/adding.html), each test includes a comment summarizing what it is about.
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ce3773f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#83729 - JohnTitor:issue-43913, r=estebank

    Add a suggestion when using a type alias instead of trait alias
    
    Fixes rust-lang#43913
    
    r? ``````@estebank``````
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    78e3463 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#84248 - calebsander:refactor/vec-functions,…

    … r=Amanieu
    
    Remove duplicated fn(Box<[T]>) -> Vec<T>
    
    `<[T]>::into_vec()` does the same thing as `Vec::from::<Box<[T]>>()`, so they can be implemented in terms of each other. This was the previous implementation of `Vec::from()`, but was changed in rust-lang#78461. I'm not sure what the rationale was for that change, but it seems preferable to maintain a single implementation.
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    13bcf03 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#84320 - jsha:details-implementors, r=Manish…

    …earth,Nemo157,GuillaumeGomez
    
    Use details tag for trait implementors.
    
    Part of rust-lang#83332 and following on from rust-lang#83337 and rust-lang#83355.
    
    This removes one category of JS-generated toggles (implementors), and replaces them with a `<details>` tag. This simplifies the JS, and fixes some bugs where things that were supposed to be hidden by the toggle were not hidden. Compare https://hoffman-andrews.com/rust/details-implementors/std/io/trait.Read.html#impl-Read vs https://doc.rust-lang.org/nightly/std/io/trait.Read.html#implementors.
    
    This introduces a `left: -23px` to put the toggle in the correct place, matching the current style for `.collapse-toggle`.
    
    It's worth noting this introduces a slight behavior change: since the entire line is now a `<summary>`, any part of the line is clickable. So for instance, in `impl Read for File`, clicking `impl` or `for` will collapse / expand the docs. Clicking `Read` or `File` still links to the appropriate documentation as before.
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    40bd335 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#84359 - lnicola:rust-analyzer-2021-04-20, r…

    …=jonas-schievink
    
    ⬆️ rust-analyzer
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e3b90b0 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#84374 - CDirkx:gitignore, r=Mark-Simulacrum

    Clean up .gitignore
    
    Categorizes entries in the `.gitignore` file.
    
    Other changes:
    - added `desktop.ini` (Windows equivalent of `.DS_Store`)
    - removed `.hg/` and `.hgignore`
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    71b03dc View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#84387 - CDirkx:poison, r=m-ou-se

    Move `sys_common::poison` to `sync::poison`
    
    `sys_common` should not contain publicly exported types, only platform-independent abstractions on top of `sys`, which `sys_common::poison` is not. There is thus no reason for the module to not live under `sync`.
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    94ef942 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#84430 - dvdhrm:rw/uefidoc, r=Amanieu

    doc/platform-support: clarify UEFI support
    
    Add missing information on what standard-library features are supported by the UEFI targets.
    
    All current UEFI targets (which is i686 and x86_64) only support no_std cross-compilations. `std` support has not been worked on and is unlikely to emerge anytime soon, due to the much restricted environment that UEFI provides.
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    75cd8dd View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#84433 - GuillaumeGomez:search-input-blur, r…

    …=jsha
    
    Prevent control, shift and alt keys to make search input lose focus
    
    Part of rust-lang#84384.
    
    r? `@jsha`
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    79a9723 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#84444 - notriddle:num-docs-from-undocumente…

    …d-items-toggle, r=yaahc
    
    rustdoc: Get rid of "[+] show undocumented items" toggle on numeric From impls
    
    On most From implementations, the docstring is attached to the function. This is also how people have been [recommended] to do it.
    
    Screenshots:
    
    * [before](https://user-images.githubusercontent.com/1593513/115767662-323c5480-a35e-11eb-9918-98aba83e9183.png)
    * [after](https://user-images.githubusercontent.com/1593513/115767675-35374500-a35e-11eb-964f-c28eeb6c807a.png)
    
    [recommended]: rust-lang#51430 (comment)
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c00bb72 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#84456 - richkadel:issue-84421, r=tmandry

    Fix ICE if original_span(fn_sig) returns a span not in body sourcefile
    
    Fixes: rust-lang#84421
    
    r? `@tmandry`
    
    fyi: `@wesleywiser` `@sdroege` `@rajivshah3`
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d3b4655 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#84464 - jyn514:type-kind, r=CraftSpider

    rustdoc: Get rid of `clean::TypeKind`
    
    It does exactly the same thing as ItemType.
    GuillaumeGomez committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f75bb0c View commit details
    Browse the repository at this point in the history