Don't rebuild rustdoc and clippy after checking bootstrap #84484
Conversation
This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`.
jyn514
added
T-bootstrap
rust-highfive
added
the
S-waiting-on-review
| @@ -321,11 +321,9 @@ macro_rules! tool_check_step { | |||
| } | |||
|
|
|||
| // Enable internal lints for clippy and rustdoc | |||
There was a problem hiding this comment.
Uh, this comment seems odd or at least in need of updates - mind removing it I guess?
Are we gating internal lints on a CLI flag being passed? I guess we're enabling them on the CLI so that makes some sense, but then I'm not sure why this piece of code is in check.rs vs. Builder::cargo or so, alongside actually enabling the lints.
Generally deny(rustc::internal) isn't quite what we want in-code too, as we want deny-warnings=false to work locally...
There was a problem hiding this comment.
Are we gating internal lints on a CLI flag being passed?
Yes, the compiler doesn't run internal lints unless -Z unstable-options is passed, even if you have #[warn(rustc::internal)].
Generally deny(rustc::internal) isn't quite what we want in-code too, as we want deny-warnings=false to work locally...
Oh good point - I'll fix it in rustdoc and update the comment.
There was a problem hiding this comment.
Oh good point - I'll fix it in rustdoc and update the comment.
Done.
These should still obey deny-warnings.
|
@bors r+ rollup |
|
📌 Commit 1c8e122 has been approved by |
bors
added
S-waiting-on-bors
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? `@Mark-Simulacrum`
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? ``@Mark-Simulacrum``
Rollup of 11 pull requests Successful merges: - rust-lang#84484 (Don't rebuild rustdoc and clippy after checking bootstrap) - rust-lang#84530 (`test tidy` should ignore alternative `build` dir patterns) - rust-lang#84531 (Ignore commented out lines when finding features) - rust-lang#84540 (Build sanitizers for x86_64-unknown-linux-musl) - rust-lang#84555 (Set `backtrace-on-ice` by default for compiler and codegen profiles) - rust-lang#84585 (Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc`) - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) - rust-lang#84646 (Add some regression tests related to rust-lang#82494) - rust-lang#84661 (Remove extra word in `rustc_mir` docs) - rust-lang#84663 (Remove `DropGuard` in `sys::windows::process` and use `StaticMutex` instead) - rust-lang#84668 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? ```@Mark-Simulacrum```
This works by unconditionally passing -Z unstable-options to the
compiler. This has no affect in practice since bootstrap doesn't use
deny(rustc::internal).Fixes #82461.
r? @Mark-Simulacrum