rustdoc: change aliases attribute to data-aliases #84636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in HTML/CSS/JS. |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
@bors r+ rollup |
|
📌 Commit 52cd14031a199b546f91d30ed9e4d5c36c54528c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2021
Rollup of 5 pull requests Successful merges: - rust-lang#84529 (Improve coverage spans for chained function calls) - rust-lang#84616 (Fix empty dom toggle) - rust-lang#84622 (Make traits with GATs not object safe) - rust-lang#84624 (Make sentence in env::args_os' docs plain and simple) - rust-lang#84642 (Stabilize vec_extend_from_within) Failed merges: - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) r? `@ghost` `@rustbot` modify labels: rollup
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-author
The "aliases" attribute is not listed [on MDN], so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future. [on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
|
@jyn514 rebased |
GuillaumeGomez
approved these changes
Apr 28, 2021
|
@bors: r=jyn514,GuillaumeGomez rollup |
|
📌 Commit b57049a has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Apr 28, 2021
…illaumeGomez rustdoc: change aliases attribute to data-aliases The "aliases" attribute is not listed [on MDN], so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future. [on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 28, 2021
…illaumeGomez rustdoc: change aliases attribute to data-aliases The "aliases" attribute is not listed [on MDN], so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future. [on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
…illaumeGomez rustdoc: change aliases attribute to data-aliases The "aliases" attribute is not listed [on MDN], so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future. [on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 29, 2021
Rollup of 11 pull requests Successful merges: - rust-lang#84484 (Don't rebuild rustdoc and clippy after checking bootstrap) - rust-lang#84530 (`test tidy` should ignore alternative `build` dir patterns) - rust-lang#84531 (Ignore commented out lines when finding features) - rust-lang#84540 (Build sanitizers for x86_64-unknown-linux-musl) - rust-lang#84555 (Set `backtrace-on-ice` by default for compiler and codegen profiles) - rust-lang#84585 (Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc`) - rust-lang#84636 (rustdoc: change aliases attribute to data-aliases) - rust-lang#84646 (Add some regression tests related to rust-lang#82494) - rust-lang#84661 (Remove extra word in `rustc_mir` docs) - rust-lang#84663 (Remove `DropGuard` in `sys::windows::process` and use `StaticMutex` instead) - rust-lang#84668 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "aliases" attribute is not listed on MDN, so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future.