Rollup of 12 pull requests #84680
Closed
Rollup of 12 pull requests #84680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`.
I need to have multiple `build` directories, such as `build`, `build-fuchsia`, and `build-test`. But when I'm uploading a change, I run `./x.py test tidy`, and if I have a `build-something` directory with Rust sources, I git a bunch of formatting errors. `rustfmt.toml` only ignores the directory named `build`. This change extends the patterns to also ignore `build-*` and `*-build`. As a rustc contributor, I not only build the rust compiler to develop new features, but I also build alternative "distributions" (using secondary `*-config.toml` files with different configurations), including: * To occasionally rebuild a version of the compiler that `rust-analyzer` can use to `check` source (which fixes issues in the VS Code UI, so changing and rebuilding the compiler does not break VS Code editing Rust code). * To build custom distributions for Fuchsia * To build test distributions when working on changes to `bootstrap` (e.g., when I recently added `rust-demangler` to distributions)
If there's an ICE while bootstrapping, it's most likely because of a change to the compiler.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
These should still obey deny-warnings.
Changes "is includes" to "includes" in `rustc_mir::borrow_check::type_check::type_check`.
The "aliases" attribute is not listed [on MDN], so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future. [on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
Don't rebuild rustdoc and clippy after checking bootstrap This works by unconditionally passing -Z unstable-options to the compiler. This has no affect in practice since bootstrap doesn't use `deny(rustc::internal)`. Fixes rust-lang#82461. r? ``@Mark-Simulacrum``
…-37508, r=Mark-Simulacrum Add test for thread-local and code-model=large Closes rust-lang#37508
…ark-Simulacrum `test tidy` should ignore alternative `build` dir patterns I need to have multiple `build` directories, such as `build`, `build-fuchsia`, and `build-test`. But when I'm uploading a change, I run `./x.py test tidy`, and if I have a `build-something` directory with Rust sources, I git a bunch of formatting errors. `rustfmt.toml` only ignores the directory named `build`. This change extends the patterns to also ignore `build-*` and `*-build`. As a rustc contributor, I not only build the rust compiler to develop new features, but I also build alternative "distributions" (using secondary `*-config.toml` files with different configurations), including: * To occasionally rebuild a version of the compiler that `rust-analyzer` can use to `check` source (which fixes issues in the VS Code UI, so changing and rebuilding the compiler does not break VS Code editing Rust code). * To build custom distributions for Fuchsia * To build test distributions when working on changes to `bootstrap` (e.g., when I recently added `rust-demangler` to distributions)
…mulacrum Ignore commented out lines when finding features This fixes rust-lang#76246, where commented out lines were being detected as features by `tidy`, by ignoring those lines when looking for features. It's still not perfect, since it can be fooled by things like: ```rust /* #[unstable(feature = "foo", issue = "1234")] */ ``` But luckily that never happens in `rustc`, so `foo` now ceases to appear in the unstable book.
…Simulacrum Build sanitizers for x86_64-unknown-linux-musl The support of sanitizers on target `x86_64-unknown-linux-musl` is landed in rust-lang#84126
…crum Set `backtrace-on-ice` by default for compiler and codegen profiles If there's an ICE while bootstrapping, it's most likely because of a change to the compiler.
…crum Add `x.py check src/librustdoc` as an alias for `x.py check src/tools/rustdoc` I keep making this typo, it would be nice for it to be supported.
…illaumeGomez rustdoc: change aliases attribute to data-aliases The "aliases" attribute is not listed [on MDN], so it sounds like it's rustdoc-specific. We don't want to conflict with any attributes that are added to the spec in the future. [on MDN]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Heading_Elements
…tests, r=Dylan-DPC Add some regression tests related to rust-lang#82494 Closes rust-lang#75883, closes rust-lang#80779 r? ```@estebank```
Remove extra word in `rustc_mir` docs Changes "is includes" to "includes" in `rustc_mir::borrow_check::type_check::type_check`.
Remove `DropGuard` in `sys::windows::process` and use `StaticMutex` instead `StaticMutex` is a mutex that when locked provides a guard that unlocks the mutex again when dropped, thus provides the exact same functionality as `DropGuard`. `StaticMutex` is used in more places, and is thus preferred over an ad-hoc construct like `DropGuard`. ```@rustbot``` label: +T-libs-impl
Update books ## reference 5 commits in e1abb17cd94cd5a8a374b48e1bc8134a2208ed48..d23f9da8469617e6c81121d9fd123443df70595d 2021-04-07 08:09:48 -0700 to 2021-04-28 11:16:44 -0700 - Document or-patterns (rust-lang/reference#957) - fixed a typo in traits.md (rust-lang/reference#1009) - Improve clarity and style consistency of crate type list (rust-lang/reference#1005) - added macro_rules to weak keywords (rust-lang/reference#1008) - Move non-ascii-idents content from unstable book to reference. (rust-lang/reference#999) ## book 1 commits in b54090a99ec7c4b46a5203a9c927fdbc311bb1f5..50dd06cb71beb27fdc0eebade5509cdcc1f821ed 2021-03-24 11:21:46 -0500 to 2021-04-23 13:21:54 -0500 - Update link in COPYRIGHT (http to https) (rust-lang/book#2704) ## rust-by-example 3 commits in c80f0b09fc15b9251825343be910c08531938ab2..e0a721f5202e6d9bec0aff99f10e44480c0da9e7 2021-04-08 10:28:17 -0300 to 2021-04-27 09:32:15 -0300 - broken long comments in src/types/cast.md to several shortones (rust-lang/rust-by-example#1430) - Fix link of formatting traits (rust-lang/rust-by-example#1410) - chore: Fix the indention of Borrowed definition (rust-lang/rust-by-example#1436) ## rustc-dev-guide 8 commits in a9bd2bbf31e4f92b5d3d8e80b22839d0cc7a2022..e72b43a64925ce053dc7830e21c1a57ba00499bd 2021-04-09 18:12:21 -0400 to 2021-04-27 12:35:37 -0700 - Suggest using `git range-diff` (rust-lang/rustc-dev-guide#1092) - Remove the possible unnecessary flag - Replace some Travis-related things completely - Trigger GHA only on the original repo - Add sample nix shell - more RA config suggestions (rust-lang/rustc-dev-guide#1114) - Add Polymorphisation paper (rust-lang/rustc-dev-guide#1093) - Mention unpretty=mir-cfg for debugging MIR
|
@bors r+ rollup=never p=12 |
|
📌 Commit 2c34c15 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 2c34c15 with merge 2be50286428fe6d73c238fd2a0eec2893dde337f... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
test tidyshould ignore alternativebuilddir patterns #84530 (test tidyshould ignore alternativebuilddir patterns)backtrace-on-iceby default for compiler and codegen profiles #84555 (Setbacktrace-on-iceby default for compiler and codegen profiles)x.py check src/librustdocas an alias forx.py check src/tools/rustdoc#84585 (Addx.py check src/librustdocas an alias forx.py check src/tools/rustdoc)rustc_mirdocs #84661 (Remove extra word inrustc_mirdocs)DropGuardinsys::windows::processand useStaticMutexinstead #84663 (RemoveDropGuardinsys::windows::processand useStaticMutexinstead)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup