Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded bottom margin on search results #84690

Merged

Conversation

GuillaumeGomez
Copy link
Member

As you can see, there is still more than enough space at the bottom:

Screenshot from 2021-04-29 11-26-57

r? @Nemo157

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Apr 29, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2021
@Nemo157
Copy link
Member

Nemo157 commented Apr 29, 2021

If anyone else tries to test manually on the current nightly docs, you need to also apply the change from #84688, without that this does remove the padding. With that change too, lgtm.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 29, 2021

📌 Commit a20831e has been approved by Nemo157

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
…in-search-results, r=Nemo157

Remove unneeded bottom margin on search results

As you can see, there is still more than enough space at the bottom:

![Screenshot from 2021-04-29 11-26-57](https://user-images.githubusercontent.com/3050060/116530090-ea797800-a8dd-11eb-8eef-2288cf68e0d2.png)

r? `@Nemo157`
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…in-search-results, r=Nemo157

Remove unneeded bottom margin on search results

As you can see, there is still more than enough space at the bottom:

![Screenshot from 2021-04-29 11-26-57](https://user-images.githubusercontent.com/3050060/116530090-ea797800-a8dd-11eb-8eef-2288cf68e0d2.png)

r? ``@Nemo157``
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…in-search-results, r=Nemo157

Remove unneeded bottom margin on search results

As you can see, there is still more than enough space at the bottom:

![Screenshot from 2021-04-29 11-26-57](https://user-images.githubusercontent.com/3050060/116530090-ea797800-a8dd-11eb-8eef-2288cf68e0d2.png)

r? ```@Nemo157```
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…in-search-results, r=Nemo157

Remove unneeded bottom margin on search results

As you can see, there is still more than enough space at the bottom:

![Screenshot from 2021-04-29 11-26-57](https://user-images.githubusercontent.com/3050060/116530090-ea797800-a8dd-11eb-8eef-2288cf68e0d2.png)

r? ````@Nemo157````
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…in-search-results, r=Nemo157

Remove unneeded bottom margin on search results

As you can see, there is still more than enough space at the bottom:

![Screenshot from 2021-04-29 11-26-57](https://user-images.githubusercontent.com/3050060/116530090-ea797800-a8dd-11eb-8eef-2288cf68e0d2.png)

r? `````@Nemo157`````
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#84451 (Use flex more consistently)
 - rust-lang#84590 (Point out that behavior might be switched on 2015 and 2018 too one day)
 - rust-lang#84682 (Don't rebind in `transitive_bounds_that_define_assoc_type`)
 - rust-lang#84683 (Minor grammar tweaks for readability to btree internals)
 - rust-lang#84688 (Remove unnecessary CSS rules for search results)
 - rust-lang#84690 (Remove unneeded bottom margin on search results)
 - rust-lang#84692 (Link between std::env::{var, var_os} and std::env::{vars, vars_os})
 - rust-lang#84705 (make feature recommendations optional)
 - rust-lang#84706 (Drop alias `reduce` for `fold` - we have a `reduce` function)
 - rust-lang#84713 (Fix labels for regression issue template)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8460539 into rust-lang:master Apr 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 30, 2021
@GuillaumeGomez GuillaumeGomez deleted the unneeded-bottom-margin-search-results branch April 30, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants