Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor grammar tweaks for readability to btree internals #84683

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

Ben-Lichtman
Copy link
Contributor

I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @yaahc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2021
@jonas-schievink
Copy link
Contributor

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 29, 2021

📌 Commit 3e016a7 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2021
…vink

Minor grammar tweaks for readability to btree internals

I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…vink

Minor grammar tweaks for readability to btree internals

I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…vink

Minor grammar tweaks for readability to btree internals

I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…vink

Minor grammar tweaks for readability to btree internals

I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
jackh726 added a commit to jackh726/rust that referenced this pull request Apr 29, 2021
…vink

Minor grammar tweaks for readability to btree internals

I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 29, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#84451 (Use flex more consistently)
 - rust-lang#84590 (Point out that behavior might be switched on 2015 and 2018 too one day)
 - rust-lang#84682 (Don't rebind in `transitive_bounds_that_define_assoc_type`)
 - rust-lang#84683 (Minor grammar tweaks for readability to btree internals)
 - rust-lang#84688 (Remove unnecessary CSS rules for search results)
 - rust-lang#84690 (Remove unneeded bottom margin on search results)
 - rust-lang#84692 (Link between std::env::{var, var_os} and std::env::{vars, vars_os})
 - rust-lang#84705 (make feature recommendations optional)
 - rust-lang#84706 (Drop alias `reduce` for `fold` - we have a `reduce` function)
 - rust-lang#84713 (Fix labels for regression issue template)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 15582fc into rust-lang:master Apr 30, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 30, 2021
@Ben-Lichtman Ben-Lichtman deleted the grammar branch May 3, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants