Rollup of 10 pull requests #84720
Closed
Rollup of 10 pull requests #84720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On bootstrap the IntoIterator trait is not implemented yet for arrays.
Searching for "reduce" currently puts the `reduce` alias for `fold` above the actual `reduce` function. The `reduce` function already has a cross-reference for `fold`, and vice versa.
Each label needs to be separated by a comma (see the ICE issue template for an example of correct usage). As a result of this problem, the `regression-untriaged` label has not been automatically added to issues opened with this template. See c127530 for another example of this.
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
Vastly improves coverage spans for macros Fixes: rust-lang#84561 This resolves problems where macros like `trace!(...)` would show zero coverage if tracing was disabled, and `assert_eq!(...)` would show zero coverage if the assertion did not fail, because only one coverage span was generated, for the branch. This PR started with an idea that I could just drop branching blocks with same span as expanded macro. (See the fixed issue for more details.) That did help, but it didn't resolve everything. I also needed to add a span specifically for the macro name (plus `!`) to ensure the macro gets coverage even if it's internal expansion adds conditional branching blocks that are retained, and would otherwise drop the outer span. Now that outer span is _only_ the `(argument, list)`, which can safely be dropped now), because the macro name has its own span. While testing, I also noticed the spanview debug output can cause an ICE on a function with no body. The workaround for this is included in this PR (separate commit). r? `````@tmandry````` cc? `````@wesleywiser`````
Point out that behavior might be switched on 2015 and 2018 too one day Reword documentation to make it clear that behaviour can be switched on older editions too, one day in the future. It doesn't *have* to be switched, but I think it's good to have it as an option and re-evaluate it a few months/years down the line when e.g. the crates that showed up in crater were broken by different changes in the language already. cc rust-lang#25725, rust-lang#65819, rust-lang#66145, rust-lang#84147 , and rust-lang#84133 (comment)
…r=nikomatsakis Don't rebind in `transitive_bounds_that_define_assoc_type` Fixes rust-lang#83737 Fixes rust-lang#84604 Also fixes another issue that I don't have a test for, popped up in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Duplicate.20symbol.20error.20.2384604/near/236570445) r? ```@nikomatsakis```
…vink Minor grammar tweaks for readability to btree internals I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
…ss-for-search-results, r=Nemo157 Remove unnecessary CSS rules for search results Discovered that this was useless when working on rust-lang/docs.rs#1382. r? ``````@Nemo157``````
…in-search-results, r=Nemo157 Remove unneeded bottom margin on search results As you can see, there is still more than enough space at the bottom:  r? ````@Nemo157````
…lett make feature recommendations optional this is what we're already doing for other feature gates, so it's better to be consistent
Drop alias `reduce` for `fold` - we have a `reduce` function Searching for "reduce" currently puts the `reduce` alias for `fold` above the actual `reduce` function. The `reduce` function already has a cross-reference for `fold`, and vice versa.
…te, r=Mark-Simulacrum Fix labels for regression issue template Each label needs to be separated by a comma (see the ICE issue template for an example of correct usage). As a result of this problem, the `regression-untriaged` label has not been automatically added to issues opened with this template. See c127530 for another example of this. r? ```@Mark-Simulacrum```
|
@bors r+ rollup=never p=10 |
|
📌 Commit b9bf541 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit b9bf541 with merge b542db173624083dad0f8a069d4af0a96e6f1f80... |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
transitive_bounds_that_define_assoc_type#84682 (Don't rebind intransitive_bounds_that_define_assoc_type)reduceforfold- we have areducefunction #84706 (Drop aliasreduceforfold- we have areducefunction)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup