Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #84718

Closed
wants to merge 28 commits into from
Closed

Commits on Apr 22, 2021

  1. Use flex more consistently.

    Tor Hovland committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    3090b01 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Configuration menu
    Copy the full SHA
    5bd3187 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Configuration menu
    Copy the full SHA
    12642d9 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Configuration menu
    Copy the full SHA
    aeb67ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c4fc3e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bbf6bce View commit details
    Browse the repository at this point in the history
  4. addressed review feedback

    richkadel committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    fd85fd3 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    31ae3b2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5f82e22 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Configuration menu
    Copy the full SHA
    3e016a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c04695 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a20831e View commit details
    Browse the repository at this point in the history
  4. Ignore doctests in bootstrap

    On bootstrap the IntoIterator trait is not implemented
    yet for arrays.
    est31 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    a352336 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da6261e View commit details
    Browse the repository at this point in the history
  6. Drop alias reduce for fold - we have a reduce function

    Searching for "reduce" currently puts the `reduce` alias for `fold`
    above the actual `reduce` function. The `reduce` function already has a
    cross-reference for `fold`, and vice versa.
    joshtriplett committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    20b569f View commit details
    Browse the repository at this point in the history
  7. Fix labels for regression issue template

    Each label needs to be separated by a comma (see the ICE issue template
    for an example of correct usage).
    
    As a result of this problem, the `regression-untriaged` label has not
    been automatically added to issues opened with this template.
    
    See c127530 for another example of this.
    camelid committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    16ff6c8 View commit details
    Browse the repository at this point in the history
  8. Add std::os::unix::fs::chroot to change the root directory of the cur…

    …rent process
    
    This is a straightforward wrapper that uses the existing helpers for C
    string handling and errno handling.
    
    Having this available is convenient for UNIX utility programs written in
    Rust, and avoids having to call the unsafe `libc::chroot` directly and
    handle errors manually, in a program that may otherwise be entirely safe
    code.
    joshtriplett committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    2fb2f0b View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#84451 - torhovland:flex, r=jsha

    Use flex more consistently
    
    Builds on rust-lang#84376, related to rust-lang#84354.
    
    - Fully replaces `float: right` with `flex` on `.content .out-of-band`.
    - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.).
    
    Tested on various widths to make sure the pages behave as before.
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6d18bcf View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#84582 - richkadel:issue-84561, r=tmandry

    Vastly improves coverage spans for macros
    
    Fixes: rust-lang#84561
    
    This resolves problems where macros like `trace!(...)` would show zero coverage if tracing was disabled, and `assert_eq!(...)` would show zero coverage if the assertion did not fail, because only one coverage span was generated, for the branch.
    
    This PR started with an idea that I could just drop branching blocks with same span as expanded macro. (See the fixed issue for more details.)
    
    That did help, but it didn't resolve everything.
    
    I also needed to add a span specifically for the macro name (plus `!`) to ensure the macro gets coverage even if it's internal expansion adds conditional branching blocks that are retained, and would otherwise drop the outer span. Now that outer span is _only_ the `(argument, list)`, which can safely be dropped now), because the macro name has its own span.
    
    While testing, I also noticed the spanview debug output can cause an ICE on a function with no body. The
    workaround for this is included in this PR (separate commit).
    
    r? ````@tmandry````
    cc? ````@wesleywiser````
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    49effb0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#84590 - est31:array_into_iter, r=nikomatsakis

    Point out that behavior might be switched on 2015 and 2018 too one day
    
    Reword documentation to make it clear that behaviour can be switched on older editions too, one day in the future. It doesn't *have* to be switched, but I think it's good to have it as an option and re-evaluate it a few months/years down the line when e.g. the crates that showed up in crater were broken by different changes in the language already.
    
    cc rust-lang#25725, rust-lang#65819, rust-lang#66145, rust-lang#84147 , and rust-lang#84133 (comment)
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    f82e345 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#84682 - jackh726:transitive_bounds_rebind, …

    …r=nikomatsakis
    
    Don't rebind in `transitive_bounds_that_define_assoc_type`
    
    Fixes rust-lang#83737
    Fixes rust-lang#84604
    
    Also fixes another issue that I don't have a test for, popped up in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/Duplicate.20symbol.20error.20.2384604/near/236570445)
    
    r? ``@nikomatsakis``
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    b88ea41 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#84683 - Ben-Lichtman:grammar, r=jonas-schie…

    …vink
    
    Minor grammar tweaks for readability to btree internals
    
    I was reading through the btree implementation and I noticed some grammar that could be improved in Node.rs so here is what I think would be a minor improvement.
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    9274e3c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#84688 - GuillaumeGomez:remove-unnecessary-c…

    …ss-for-search-results, r=Nemo157
    
    Remove unnecessary CSS rules for search results
    
    Discovered that this was useless when working on rust-lang/docs.rs#1382.
    
    r? `````@Nemo157`````
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    dbaefd3 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#84690 - GuillaumeGomez:unneeded-bottom-marg…

    …in-search-results, r=Nemo157
    
    Remove unneeded bottom margin on search results
    
    As you can see, there is still more than enough space at the bottom:
    
    ![Screenshot from 2021-04-29 11-26-57](https://user-images.githubusercontent.com/3050060/116530090-ea797800-a8dd-11eb-8eef-2288cf68e0d2.png)
    
    r? ```@Nemo157```
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    d2c6ba2 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#84705 - lcnr:const_generics-rec, r=joshtrip…

    …lett
    
    make feature recommendations optional
    
    this is what we're already doing for other feature gates, so it's better to be consistent
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    6f279a3 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#84706 - joshtriplett:reduce-aliases, r=m-ou-se

    Drop alias `reduce` for `fold` - we have a `reduce` function
    
    Searching for "reduce" currently puts the `reduce` alias for `fold`
    above the actual `reduce` function. The `reduce` function already has a
    cross-reference for `fold`, and vice versa.
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    39f0fdc View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#84713 - camelid:fix-regression-issue-templa…

    …te, r=Mark-Simulacrum
    
    Fix labels for regression issue template
    
    Each label needs to be separated by a comma (see the ICE issue template
    for an example of correct usage).
    
    As a result of this problem, the `regression-untriaged` label has not
    been automatically added to issues opened with this template.
    
    See c127530 for another example of this.
    
    r? ``@Mark-Simulacrum``
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    7702e48 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#84716 - joshtriplett:chroot, r=dtolnay

    Add std::os::unix::fs::chroot to change the root directory of the current process
    
    This is a straightforward wrapper that uses the existing helpers for C
    string handling and errno handling.
    
    Having this available is convenient for UNIX utility programs written in
    Rust, and avoids having to call the unsafe `libc::chroot` directly and
    handle errors manually, in a program that may otherwise be entirely safe
    code.
    jackh726 committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    ac134c3 View commit details
    Browse the repository at this point in the history