Rollup of 11 pull requests #86527
Merged
Rollup of 11 pull requests #86527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was erroneously changed in rust-lang#83387
Revert SGX inline asm syntax This was erroneously changed in rust-lang#83387
…nTitor Move `available_concurrency` implementation to `sys` This splits out the platform-specific implementation of `available_concurrency` to the corresponding platforms under `sys`. No changes are made to the implementation. Tidy didn't lint against this code being originally added outside of `sys` because of a bug (see rust-lang#84677), this PR also reverts the exclusion that was introduced in that bugfix. Tracking issue of `available_concurrency`: rust-lang#74479
Add `io::Cursor::{remaining, remaining_slice, is_empty}`
Tracking issue: rust-lang#86369
I came across an inconvenience when answering the following [Stack Overflow](https://stackoverflow.com/questions/67831170) question.
To get the remaining slice you have to call `buff.fill_buf().unwrap()`. Which in my opinion doesn't really tell you what is returned (in the context of Cursor). To improve readability and convenience when using Cursor i propose adding the method `remaining`.
The next thing i found inconvenient (unnecessary long) was detecting if the cursor reached the end. There are a few ways this can be achieved right now:
- `buff.fill_buf().unwrap().is_empty()`
- `buff.position() >= buff.get_ref().len()`
- `buff.bytes().next().is_none()`
Which all seem a bit unintuitive, hidden in trait documentations or just a bit long for such a simple task.
Therefor i propose another method called `is_empty`, maybe with another name, since this one may leave room for interpretation on what really is empty (the underlying slice, the remaining slice or maybe the position).
Since it seemed easier to create this PR instead of an RFC i did that, if an RFC is wanted, i can close this PR and write an RFC first.
…r=yaahc Reopen rust-lang#79692 (Format symbols under shared frames) Reopening rust-lang#79692.
…Mark-Simulacrum Allow to pass arguments to rustdoc-gui tool Very convenient for testing. This is another part of rust-lang#86293 cc ``@jsha`` r? ``@Mark-Simulacrum``
…iases, r=jyn514 Resolve type aliases to the type they point to in intra-doc links This feels a bit sketchy, but I think it's better than just rejecting the link. Helps with rust-lang#86120, r? ``@jyn514``
Fix comment about rustc_inherit_overflow_checks in abs().
…ohnTitor Add regression test for issue rust-lang#39161 Closes rust-lang#39161 Based on feedback from ``@JohnTitor`` in rust-lang#71333 r? ``@JohnTitor``
…r=Mark-Simulacrum Remove `#[allow(unused_lifetimes)]` which is now unnecessary Seems FP has been fixed, it doesn't need `#[allow(unused_lifetimes)]` anymore.
…ark-Simulacrum Add regression test for issue rust-lang#54685 Closes rust-lang#54685 Took the test from rust-lang#54685 and modified it a bit to use assertion. Made sure that the updated test catches the original issue on 1.50 by running on Compiler Explorer (https://godbolt.org/z/E64onYeT5).
…twco Say "this enum variant takes"/"this struct takes" instead of "this function takes" This makes error messages for functions with incorrect argument counts adapt if they refer to a struct or enum variant: ``` error[E0061]: this enum variant takes 1 argument but 0 arguments were supplied --> $DIR/struct-enum-wrong-args.rs:7:13 | LL | let _ = Ok(); | ^^-- supplied 0 arguments | | | expected 1 argument error[E0061]: this struct takes 1 argument but 0 arguments were supplied --> $DIR/struct-enum-wrong-args.rs:8:13 | LL | let _ = Wrapper(); | ^^^^^^^-- supplied 0 arguments | | | expected 1 argument ``` Fixes rust-lang#86481.
|
@bors r+ p=11 rollup=never |
|
📌 Commit 4495ce7 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
available_concurrencyimplementation tosys#85182 (Moveavailable_concurrencyimplementation tosys)io::Cursor::{remaining, remaining_slice, is_empty}#86037 (Addio::Cursor::{remaining, remaining_slice, is_empty})..in struct expr with all fields present, in a const ("error[E0016]: blocks in constants are limited to items and tail expressions") #39161)#[allow(unused_lifetimes)]which is now unnecessary #86387 (Remove#[allow(unused_lifetimes)]which is now unnecessary)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup