Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CSS class instead of using inline style for search results #92610

Merged

Conversation

GuillaumeGomez
Copy link
Member

I saw this change in the update you proposed in #92404. :)

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Jan 6, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2022
@GuillaumeGomez GuillaumeGomez force-pushed the css-class-instead-of-inline-style branch from ac37c9a to 26edfc9 Compare January 6, 2022 14:12
@GuillaumeGomez
Copy link
Member Author

Forgot that the ES6 PR wasn't merged yet...

@jsha
Copy link
Contributor

jsha commented Jan 6, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 6, 2022

📌 Commit 26edfc9 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 6, 2022
…-inline-style, r=jsha

Create CSS class instead of using inline style for search results

I saw this change in the update you proposed in rust-lang#92404. :)

r? `@jsha`
@ehuss ehuss mentioned this pull request Jan 8, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2022
Rollup of 8 pull requests

Successful merges:

 - rust-lang#84640 (Implement `TryFrom<char>` for `u8`)
 - rust-lang#92336 (Remove &self from PrintState::to_string)
 - rust-lang#92375 (Consolidate checking for msvc when generating debuginfo)
 - rust-lang#92568 (Add note about non_exhaustive to variant_count)
 - rust-lang#92600 (Add some missing `#[must_use]` to some `f{32,64}` operations)
 - rust-lang#92610 (Create CSS class instead of using inline style for search results)
 - rust-lang#92632 (Implement stabilization of `#[feature(available_parallelism)]`)
 - rust-lang#92650 (Fix typo in `StableCrateId` docs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 759b13e into rust-lang:master Jan 8, 2022
@rustbot rustbot added this to the 1.59.0 milestone Jan 8, 2022
@GuillaumeGomez GuillaumeGomez deleted the css-class-instead-of-inline-style branch January 8, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants