Rollup of 7 pull requests #92616
Closed
Rollup of 7 pull requests #92616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update Node to v16.9.0, es-check to 6.1.1, and eslint to 8.6.0.
This reduces clutter on doc pages.
…pointee, r=jackh726 Normalize struct tail type when checking Pointee trait Let's go ahead and implement the FIXMEs by properly normalizing the struct-tail type when satisfying a Pointee obligation. This should fix the ICE when we try to calculate a layout depending on `<Ty as Pointee>::Metadata` later. Fixes rust-lang#92128 Additionally, mark the obligation as ambiguous if there are any infer types in that struct-tail type. This has the effect of causing `<_ as Pointee>::Metadata` to be properly replaced with an infer variable ([here](https://github.com/rust-lang/rust/blob/master/compiler/rustc_trait_selection/src/traits/project.rs#L813)) and registered as an obligation... this turns out to be very important in unifying function parameters with formals that are assoc types. Fixes rust-lang#91446 Fixes rust-lang#92248
…Gomez Move crate drop-down to search results page This reduces clutter on doc pages. Part of rust-lang#59840 r? ``@GuillaumeGomez`` Demo: https://rustdoc.crud.net/jsha/crates-in-results/std/index.html?search=str
…=cjgillot Don't resolve blocks in foreign functions Although it is an error for a foreign function to have a block, it is still possible at the level of the AST. rust-lang#74204 made AST lowering skip over blocks belonging to foreign functions, since they're invalid. However, resolve still treated these blocks normally, resulting in a mismatch between the HIR and resolve, which could cause an ICE under certain circumstances. This PR changes resolve to skip over blocks belonging to foreign functions, as AST lowering does. Fixes rust-lang#91370. r? `@cjgillot`
Allow unwinding from OOM hooks This is split off from rust-lang#88098 and contains just the bare minimum to allow specifying a custom OOM hook with `set_alloc_error_hook` which unwinds instead of aborting. See rust-lang#88098 for an actual command-line flag which switches the default OOM behavior to unwind instead of aborting. Previous perf results show a negligible impact on performance.
…ant-count, r=the8472 Add note about non_exhaustive to variant_count Since `variant_count` isn't returning something opaque, I thought it makes sense to explicitly call out that its return value may change for some enums. cc rust-lang#73662
…htriplett
Add some missing `#[must_use]` to some `f{32,64}` operations
This PR adds `#[must_use]` to the following methods:
- `f32::recip`
- `f32::max`
- `f32::min`
- `f32::maximum`
- `f32::minimum`
and their equivalents in `f64`.
These methods all produce a new value without modifying the original and so are pointless to call without using the result.
…-inline-style, r=jsha Create CSS class instead of using inline style for search results I saw this change in the update you proposed in rust-lang#92404. :) r? `@jsha`
rustbot
added
T-compiler
|
@bors r+ rollup=never p=7 |
|
📌 Commit 7b6c940 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 7b6c940 with merge d2a3afdb07b25a2785bf85badc10ecce8bcef5fd... |
|
Looks like |
|
Yeah, I was just about to mention. It appears to be hung. Kill the build and start over? Otherwise this will probably keep going till the 6 hour timeout, which seems like a bit of a waste given the current size of the queue. |
|
@bors force retry |
|
@bors force |
|
@bors r- |
bors
added
S-waiting-on-review
|
I left T-infra a message about this. The latest spurious failure seems like the ordinary kind. Still, the first two failures were really strange. |
|
@bors retry curl: (56) OpenSSL SSL_read: Connection reset by peer, errno 54 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7b6c940 with merge b4616d1d68acaf5c99c140fc73ab24cb024d0064... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry error: failed to download from |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 7b6c940 with merge 9218ac783a4f444246685d71c410c042bd040fbd... |
|
@bors retry dist-x86_64-msvc-alt did not start. |
|
⌛ Testing commit 7b6c940 with merge bc1945fe82ab4554d256e923080e9b290e0ece32... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[must_use]to somef{32,64}operations #92600 (Add some missing#[must_use]to somef{32,64}operations)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup