Skip pointing out ambiguous impls in alloc/std crates too in inference errors #93469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
same mir-opt failures cc #93384 |
|
☔ The latest upstream changes (presumably #92007) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me after rebase |
estebank
changed the title
compiler-errors
force-pushed
the
issue-93450
branch
from
40436bc
to
9072c8d
Compare
|
Rebased and ready for r+ |
JohnCSimon
added
S-waiting-on-review
|
@compiler-errors was this PR already approved pending the rebase (comment)? |
|
@bors r+ |
|
@bors r=estebank |
|
📌 Commit 9072c8d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#91981 (Recover suggestions and useful information lost in previous PR) - rust-lang#93469 (Skip pointing out ambiguous impls in alloc/std crates too in inference errors) - rust-lang#95335 (Move resolve_path to rustc_builtin_macros and make it private) - rust-lang#95340 (interpret: with enforce_number_validity, ensure integers are truly Scalar::Int (i.e., no pointers)) - rust-lang#95341 (ARMv6K Horizon OS has_thread_local support) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the logic in
annotate_source_of_ambiguityto skip printing ambiguity errors traits inallocandstdas well, not justcore.While this does spot-fix the issue mentioned below, it would be nicer to generalize this logic, for example to detect when the trait predicate's
self_tyhas any numerical inference variables. Is it worthwhile to scrap this solution for one like that?Fixes #93450
r? @estebank
feel free to reassign