ARMv6K Horizon OS has_thread_local support #95341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocal Enable #[thread_local] on armv6k-nintendo-3ds
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 419b630 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 26, 2022
ARMv6K Horizon OS has_thread_local support cc. `@ian-h-chamberlain` cc. `@AzureMarker` Being an ARM target, it has always had built-in support for `#[thread_local]`. This PR comes in just now because we were testing `std::thread` support with `thread_local_dtor`s. This will hopefully be the last PR for the target specification, unless anymore features will be needed as time goes on.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Mar 26, 2022
ARMv6K Horizon OS has_thread_local support cc. ``@ian-h-chamberlain`` cc. ``@AzureMarker`` Being an ARM target, it has always had built-in support for `#[thread_local]`. This PR comes in just now because we were testing `std::thread` support with `thread_local_dtor`s. This will hopefully be the last PR for the target specification, unless anymore features will be needed as time goes on.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#91981 (Recover suggestions and useful information lost in previous PR) - rust-lang#93469 (Skip pointing out ambiguous impls in alloc/std crates too in inference errors) - rust-lang#95335 (Move resolve_path to rustc_builtin_macros and make it private) - rust-lang#95340 (interpret: with enforce_number_validity, ensure integers are truly Scalar::Int (i.e., no pointers)) - rust-lang#95341 (ARMv6K Horizon OS has_thread_local support) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc. @ian-h-chamberlain
cc. @AzureMarker
Being an ARM target, it has always had built-in support for
#[thread_local]. This PR comes in just now because we were testingstd::threadsupport withthread_local_dtors. This will hopefully be the last PR for the target specification, unless anymore features will be needed as time goes on.