Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc_query_impl: reduce visibility of some modules/fn's #93748

Merged
merged 2 commits into from
Feb 9, 2022
Merged

rustc_query_impl: reduce visibility of some modules/fn's #93748

merged 2 commits into from
Feb 9, 2022

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Feb 7, 2022

Locally this reduces number of exported functions from 15221 -> 14952 and size a little.

Perf run please?

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 7, 2022
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 7, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Feb 7, 2022

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 7, 2022
@bors
Copy link
Contributor

bors commented Feb 7, 2022

⌛ Trying commit eb3b29f with merge 5c7404dcd7c6a60951fab1a5f3ace7b51793769f...

@bors
Copy link
Contributor

bors commented Feb 8, 2022

☀️ Try build successful - checks-actions
Build commit: 5c7404dcd7c6a60951fab1a5f3ace7b51793769f (5c7404dcd7c6a60951fab1a5f3ace7b51793769f)

@rust-timer
Copy link
Collaborator

Queued 5c7404dcd7c6a60951fab1a5f3ace7b51793769f with parent f52c318, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5c7404dcd7c6a60951fab1a5f3ace7b51793769f): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 8, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Feb 8, 2022

Even if there is no perf effect, still an appreciated cleanup.
@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Feb 8, 2022

📌 Commit eb3b29f has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2022
@JohnTitor JohnTitor mentioned this pull request Feb 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 9, 2022
@bors
Auto merge of rust-lang#93795 - JohnTitor:rollup-n0dmsoo, r=JohnTitor
bf242bb 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#93445 (Add From<u8> for ExitCode)
 - rust-lang#93694 (rustdoc: tweak line spacing and paragraph spacing for accessibility)
 - rust-lang#93735 (Stabilize int_abs_diff in 1.60.0.)
 - rust-lang#93746 (Remove defaultness from ImplItem.)
 - rust-lang#93748 (rustc_query_impl: reduce visibility of some modules/fn's)
 - rust-lang#93751 (Drop tracking: track borrows of projections)
 - rust-lang#93781 (update `ty::TyKind` documentation)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 68fa9b1 into rust-lang:master Feb 9, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@klensy @rust-highfive @cjgillot @rust-timer @bors @rustbot