kmc-solid: Use libc::abort to abort a program
#95916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation uses a `hlt` instruction, which is the most direct way to notify a connected debugger but is not the most flexible way. This commit changes it to a call to the `abort` libc function, making it possible for a system designer to override its behavior as they see fit.
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
kawadakk
changed the title
abort to abort a programlibc::abort to abort a program
|
Hi @kennytm, any updates on this? |
apiraino
added
the
T-libs
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#95040 (protect `std::io::Take::limit` from overflow in `read`) - rust-lang#95916 (kmc-solid: Use `libc::abort` to abort a program) - rust-lang#99494 (Use non-relocatable code in nofile-limit.rs test) - rust-lang#99581 (Improve error messages involving `derive` and `packed`.) - rust-lang#99643 (Add `sign-ext` target feature to the WASM target) - rust-lang#99659 (Use `VecMap::get` in `ConstraintLocator::check`) - rust-lang#99690 (add miri-track-caller to more intrinsic-exposing methods) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the target-specific abort subroutine for the
*-kmc-solid_*Tier 3 targets.The current implementation uses a
hltinstruction, which is the most direct way to notify a connected debugger but is not the most flexible way. This PR changes it to call theabortlibc function, making it possible for a system designer to override its behavior as they see fit.