Fix misleading cannot infer type for type parameter error
#97109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
r? @oli-obk (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
May 17, 2022
compiler/rustc_infer/src/infer/error_reporting/need_type_info.rs
Outdated
Show resolved
Hide resolved
|
Looks like there are more tests that need blessing. If they aren't available locally, maybe you need to rebase |
oli-obk
reviewed
May 20, 2022
| let var_origin = ty_vars.var_origin(ty_vid); | ||
| if let TypeVariableOriginKind::TypeParameterDefinition(_, Some(def_id)) = | ||
| var_origin.kind | ||
| && let Some(parent_def_id) = self.tcx.parent(def_id).as_local() |
There was a problem hiding this comment.
Doesn't have to happen in.this PR, but we could extend this to Node::ImplItem, too, so that we'd show it for associated functions
TaKO8Ki
force-pushed
the
fix-misleading-cannot-infer-type-for-type-parameter-error
branch
from
be6448b
to
0ed8d91
Compare
fix ci error emit err for `impl_item`
TaKO8Ki
force-pushed
the
fix-misleading-cannot-infer-type-for-type-parameter-error
branch
from
0ed8d91
to
3d0f9fb
Compare
|
@bors r+ rollup Thanks for doing all these changes! |
|
📌 Commit 3d0f9fb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#97109 (Fix misleading `cannot infer type for type parameter` error) - rust-lang#97187 (Reverse condition in Vec::retain_mut doctest) - rust-lang#97201 (Fix typo) - rust-lang#97203 (Minor tweaks to rustc book summary formatting.) - rust-lang#97208 (Do not emit the lint `unused_attributes` for *inherent* `#[doc(hidden)]` associated items) - rust-lang#97215 (Add complexity estimation of iterating over HashSet and HashMap) - rust-lang#97220 (Add regression test for#81827) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
TaKO8Ki
deleted the
fix-misleading-cannot-infer-type-for-type-parameter-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #93198