Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not emit the lint unused_attributes for *inherent* #[doc(hidden)] associated items #97208

Merged
merged 1 commit into from
May 20, 2022

Conversation

fmease
Copy link
Member

@fmease fmease commented May 20, 2022

Fixes #97205 (embarrassing oversight from #96008).

@rustbot label A-lint

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. labels May 20, 2022
@fmease
Copy link
Member Author

fmease commented May 20, 2022

r? @rust-lang/compiler

@oli-obk
Copy link
Contributor

oli-obk commented May 20, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 20, 2022

📌 Commit e725273 has been approved by oli-obk

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 20, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 20, 2022
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#97109 (Fix misleading `cannot infer type for type parameter` error)
 - rust-lang#97187 (Reverse condition in Vec::retain_mut doctest)
 - rust-lang#97201 (Fix typo)
 - rust-lang#97203 (Minor tweaks to rustc book summary formatting.)
 - rust-lang#97208 (Do not emit the lint `unused_attributes` for *inherent* `#[doc(hidden)]` associated items)
 - rust-lang#97215 (Add complexity estimation of iterating over HashSet and HashMap)
 - rust-lang#97220 (Add regression test for#81827)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2941434 into rust-lang:master May 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 20, 2022
@fmease fmease deleted the fix-issue-97205 branch May 20, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive unused_attributes lint on doc(hidden) attribute on non-trait associated item
4 participants