Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #97742

Merged
merged 13 commits into from Jun 5, 2022
Merged

Rollup of 6 pull requests #97742

merged 13 commits into from Jun 5, 2022

Commits on Jun 3, 2022

  1. Configuration menu
    Copy the full SHA
    4990021 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2022

  1. Configuration menu
    Copy the full SHA
    7026845 View commit details
    Browse the repository at this point in the history
  2. Adapt rustc_data_structures tests to run in strict miri

    Some tests took too long and owning_ref is fundamentally flawed,
    so don't run these tests or run them with a shorter N. This makes
    miri with `-Zmiri-strict-provenance` usable to find UB.
    Nilstrieb committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    fc8b13c View commit details
    Browse the repository at this point in the history
  3. Fix stacked borrows invalidation in rustc_data_structures sip128

    It creates the src pointer first, which is then invalidated by a
    unique borrow of the destination pointer. Swap the borrows around
    to fix this. Found with miri.
    Nilstrieb committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    7e3bee6 View commit details
    Browse the repository at this point in the history
  4. Don't generate "Impls on Foreign Types" for std

    Hack: many traits and types in std are re-exported from core or alloc. In
    general, rustdoc is capable of recognizing these implementations as being
    on local types. However, in at least one case, rustdoc gets confused and
    labels an implementation as being on a foreign type. To make sure that
    confusion doesn't pass on to the reader, consider all implementations in
    std, core, and alloc to be on local types.
    jsha committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    784eebc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    76c6845 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dd38fec View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#97609 - Elliot-Roberts:unused-trait-refacto…

    …r, r=cjgillot
    
    Iterate over `maybe_unused_trait_imports` when checking dead trait imports
    
    Closes rust-lang#96873
    r? `@cjgillot`
    
    Some questions, if you have time:
    
    - Is there a way to shorten the `rustc_data_structures::fx::FxIndexSet` path in the query declaration? I wasn't sure where to put a `use`.
    - Was returning by reference from the query the right choice here?
    - How would I go about evaluating the importance of the `is_dummy()` call in `check_crate`? I don't see failing tests when I comment it out. Should I just try to determine whether dummy spans can ever be put into `maybe_unused_trait_imports`?
    - Am I doing anything silly with the various ID types?
    - Is that `let-else` with `unreachable!()` bad? (i.e is there a better idiom? Would `panic!("<explanation>")` be better?)
    - If I want to evaluate the perf of using a `Vec` as mentioned in rust-lang#96873, is the best way to use the CI or is it feasible locally?
    
    Thanks :)
    matthiaskrgr committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    326315b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#97688 - RalfJung:test-const-cpy, r=Mark-Sim…

    …ulacrum
    
    test const_copy to make sure bytewise pointer copies are working
    
    This is non-trivial; for `swap_nonoverlapping`, this is [not working](rust-lang#83163 (comment)).
    matthiaskrgr committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    36a16be View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#97707 - Nilstrieb:data-structures-ub, r=cjg…

    …illot
    
    Improve soundness of rustc_data_structures
    
    Make it runnable in miri by adding some ignores and changing N in miri. Also fix a stacked borrows issue in sip128.
    matthiaskrgr committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    0145321 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#97731 - JohnTitor:issue-87142, r=compiler-e…

    …rrors
    
    Add regresion test for rust-lang#87142
    
    Closes rust-lang#87142
    r? `@compiler-errors`
    matthiaskrgr committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    c857265 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#97735 - jsha:no-foreign-std, r=GuillaumeGomez

    Don't generate "Impls on Foreign Types" for std
    
    Hack: many traits and types in std are re-exported from core or alloc. In general, rustdoc is capable of recognizing these implementations as being on local types. However, in at least one case, rustdoc gets confused and labels an implementation as being on a foreign type. To make sure that confusion doesn't pass on to the reader, consider all implementations in std, core, and alloc to be on local types.
    
    Demo: https://rustdoc.crud.net/jsha/no-foreign-std/std/clone/trait.Clone.html
    matthiaskrgr committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    8d0de3a View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#97737 - jackh726:verbose-pretty-printing-fi…

    …x, r=compiler-errors
    
    Fix pretty printing named bound regions under -Zverbose
    
    Fixed regression introduced in rust-lang#97023
    
    r? `@compiler-errors`
    
    cc `@cjgillot`
    matthiaskrgr committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    1794309 View commit details
    Browse the repository at this point in the history