Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accidental uses of &A: Allocator #98233

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Remove accidental uses of &A: Allocator #98233

merged 2 commits into from
Jun 19, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 18, 2022 •
edited
Loading

Cc #98232

Fixes #98176 (for real this time)

@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 18, 2022
@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 18, 2022
@RalfJung RalfJung mentioned this pull request Jun 18, 2022
Closed
@RalfJung
Copy link
Member Author

r? @thomcc

@rust-highfive rust-highfive assigned thomcc and unassigned kennytm Jun 18, 2022
@thomcc
Copy link
Member

thomcc commented Jun 18, 2022

LGTM.

@bors r+

@bors
Copy link
Contributor

bors commented Jun 18, 2022

📌 Commit b05d71f has been approved by thomcc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 19, 2022
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 19, 2022
@Dylan-DPC
Rollup merge of rust-lang#98233 - RalfJung:ref-alloc, r=thomcc
17cfc77 
Remove accidental uses of `&A: Allocator`

Cc rust-lang#98232

Fixes rust-lang#98176 (for real this time)
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2022
@bors
Auto merge of rust-lang#98255 - Dylan-DPC:rollup-hr129rg, r=Dylan-DPC
68d0b29 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#98105 (rustdoc: remove tuple link on round braces)
 - rust-lang#98136 (Rename `impl_constness` to `constness`)
 - rust-lang#98146 (Remove --memory-init-file flag when linking with Emscripten)
 - rust-lang#98219 (Skip late bound regions in GATSubstCollector)
 - rust-lang#98233 (Remove accidental uses of `&A: Allocator`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6a2a56d into rust-lang:master Jun 19, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 19, 2022
@RalfJung RalfJung deleted the ref-alloc branch June 21, 2022 23:30
@RalfJung RalfJung mentioned this pull request Jun 21, 2022
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 22, 2022
@JohnTitor
Rollup merge of rust-lang#98363 - RalfJung:btree-test-ref-alloc, r=th…
ae8c200 
…omcc

remove use of &Alloc in btree tests

I missed these in rust-lang#98233.

r? `@thomcc`
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jun 22, 2022
@JohnTitor
Rollup merge of rust-lang#98363 - RalfJung:btree-test-ref-alloc, r=th…
db64923 
…omcc

remove use of &Alloc in btree tests

I missed these in rust-lang#98233.

r? ``@thomcc``
workingjubilee pushed a commit to tcdi/postgrestd that referenced this pull request Sep 15, 2022
@JohnTitor
Rollup merge of #98363 - RalfJung:btree-test-ref-alloc, r=thomcc
a8a9d2d 
remove use of &Alloc in btree tests

I missed these in rust-lang/rust#98233.

r? ``@thomcc``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

ICE: invalid scalar pair layout
6 participants
@RalfJung @rust-highfive @thomcc @bors @kennytm @rustbot