Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to clap 3. #1142

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Upgrade to clap 3. #1142

merged 3 commits into from
Jan 18, 2022

Commits on Jan 11, 2022

  1. Upgrade to clap 3. 

    This requires moving away from the deprecated `clap_app!` macro. Clap's
derive API (formerly `StructOpt`) is nicer anyway, because it's not
stringly-typed.

There is quite a bit of furniture moving in `execute.rs` to better
separate the perf tools used for `bench_*` subcommands from those used
for the profile subcommands.
    @nnethercote
    nnethercote committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    daf36a4 View commit details
    Browse the repository at this point in the history

  2. Address review comments.

    @nnethercote
    nnethercote committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    60df383 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2022

  1. Upgrade database to clap 3. 

    Pretty minor stuff, mostly renamed functions.
    @nnethercote
    nnethercote committed Jan 17, 2022
    Configuration menu
    Copy the full SHA
    cc9e711 View commit details
    Browse the repository at this point in the history