-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 128bit numbers #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
added
the
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
label
Jul 7, 2019
bjorn3
force-pushed
the
wip_i128
branch
4 times, most recently
from
July 24, 2019 15:33
27fddc7
to
a6903b1
Compare
128bit multiplication is currently failing, because checked binops are not yet implemented for 64bit integers. Note to self
Edit: #646 implemented checked binops, making 128bit multiplication succeed 🎉 |
bjorn3
added
the
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
label
Jul 26, 2019
Switched to use my own fork of cranelift. This means that we don't have to wait for bytecodealliance/cranelift#795 to land. |
Going to merge this, as it blocks compilation of many crates. |
bjorn3
added a commit
that referenced
this pull request
Jul 26, 2019
These parts are no longer necessary as of #627
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
S-blocked
Status: marked as blocked ❌ on something else such as an RFC or other implementation work.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on bytecodealliance/cranelift#795