Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --toolchain option to 'rustup doc' #1478

Merged
merged 2 commits into from
Sep 13, 2018
Merged

Add --toolchain option to 'rustup doc' #1478

merged 2 commits into from
Sep 13, 2018

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Aug 8, 2018

Fix #1477

nrc
nrc reviewed Sep 3, 2018
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but could you add a test please?

@pickfire
Copy link
Contributor Author

pickfire commented Sep 3, 2018

@nrc I am not sure where can I add tests for this. I checked but the shorthand is handled by somewhere else so should we even add tests for this?

@pickfire
Copy link
Contributor Author

Added tests with simple check to test if toolchain is working with nightly.

@nrc
Copy link
Member

nrc commented Sep 13, 2018

Great, thank you

@nrc nrc merged commit c3e4ce4 into rust-lang:master Sep 13, 2018
@pickfire pickfire deleted the doc-toolchain branch September 13, 2018 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrc nrc nrc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pickfire @nrc