Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run basic 2018 edition fix #1583

Merged
merged 1 commit into from Dec 18, 2018
Merged

Run basic 2018 edition fix #1583

merged 1 commit into from Dec 18, 2018

Conversation

@kinnison
Copy link
Collaborator

kinnison commented Dec 18, 2018

In order to use 2018 features we need the edition to be updated.
This commit is the result of running:

cargo fix --edition -p rustup -p rustup-dist -p rustup-mock -p rustup-utils -p download

And then adding 'edition = "2018"' to each requisite Cargo.toml

In order to use 2018 features we need the edition to be updated.
This commit is the result of running:

cargo fix --edition -p rustup -p rustup-dist -p rustup-mock -p rustup-utils -p download

And then adding 'edition = "2018"' to each requisite Cargo.toml
@kinnison

This comment has been minimized.

Copy link
Collaborator Author

kinnison commented Dec 18, 2018

As a followup if this is accepted, I intend to sort out a cargo fmt across the workspace. If anyone knows of a good way to mechanically do this to preserve as much authorship information as possible, I'd love to know, otherwise it'll just smear my name across an awful lot of the codebase :(

@nrc nrc merged commit 31935e5 into rust-lang:master Dec 18, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nrc

This comment has been minimized.

Copy link
Member

nrc commented Dec 18, 2018

Thank you!

@kinnison kinnison deleted the kinnison:kinnison/edition-2018 branch Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.