Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRun basic 2018 edition fix #1583
Merged
Conversation
In order to use 2018 features we need the edition to be updated. This commit is the result of running: cargo fix --edition -p rustup -p rustup-dist -p rustup-mock -p rustup-utils -p download And then adding 'edition = "2018"' to each requisite Cargo.toml
This comment has been minimized.
This comment has been minimized.
As a followup if this is accepted, I intend to sort out a cargo fmt across the workspace. If anyone knows of a good way to mechanically do this to preserve as much authorship information as possible, I'd love to know, otherwise it'll just smear my name across an awful lot of the codebase :( |
This comment has been minimized.
This comment has been minimized.
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kinnison commentedDec 18, 2018
In order to use 2018 features we need the edition to be updated.
This commit is the result of running:
cargo fix --edition -p rustup -p rustup-dist -p rustup-mock -p rustup-utils -p download
And then adding 'edition = "2018"' to each requisite Cargo.toml