Correctly handle update across missing nightlies #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinnison
approved these changes
Sep 18, 2019
|
I've asked the tests to re-try |
This check is necessary for tests and other misbehaving repos where the currently installed nightly may suddenly turn out to no longer be a viable install candidate (e.g., because a component was retroactively removed).
jonhoo
force-pushed
the
skip-missing
branch
from
987359f
to
fd042e9
Compare
|
I pushed a change now that limit the backtracking explicitly to the date of the currently installed nightly, or alternatively the date of the first manifest ever (though I don't think that case is ever hit). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2001.