Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a better error message when a component isn't installed for a custom toolchain #2487

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 13, 2020

Closes #2470.

I did the thing you told me not to do which is mention x.py :P let me know if I should remove it.

I'm not sure how to run a custom rustup without installing it on top of my existing install ... cargo run gives me

warning: it looks like you have an existing installation of Rust at:
warning: /home/joshua/.local/lib/cargo/bin
warning: rustup should not be installed alongside Rust. Please uninstall your existing Rust first.
warning: Otherwise you may have confusion unless you are careful with your PATH
warning: If you are sure that you want both rustup and your already installed Rust
warning: then please reply `y' or `yes' or set RUSTUP_INIT_SKIP_PATH_CHECK to yes
warning: or pass `-y' to ignore all ignorable checks.
error: cannot install while Rust is installed

Is there a way to test this by hand or do you only have unit tests? I want to see what the output looks like.

@kinnison
Copy link
Contributor

Personally I do cargo run -- --no-modify-path -y but it sounds like you have an odd setup there.

I think CONTRIBUTING.md carries some instructions on setting up a custom cargo home.

Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty close to spot on. I'll even forgive the x.py providing you tweak the wording a bit.

src/errors.rs Show resolved Hide resolved
src/errors.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please rebase to remove the response commit now I've checked it.

…stom toolchain

This re-orders imports because rustfmt really wants them to change.
@jyn514
Copy link
Member Author

jyn514 commented Sep 15, 2020

Rebased :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give a better error message when a component is missing with a linked toolchain
2 participants