Correctly "detect" host endianness on MIPS #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xen0n
force-pushed
the
mips-endianness
branch
from
054c254
to
21dab8f
Compare
Counter-intuitively, Linux on MIPS reports the same machine name in `uname(2)` output, regardless of endianness. So the current check is bogus, and will fail on little-endian boxes. However, because the endianness is not runtime reconfigurable, binaries are guaranteed to only work on platforms with the same endianness. Hence, we can rely on compile-time `cfg()` checks to provide the correct host triple, despite the kernel not providing that information.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Counter-intuitively, Linux on MIPS reports the same machine name in
uname(2)output, regardless of endianness. So the current check isbogus, and will fail on little-endian boxes. However, because the endianness
is not runtime reconfigurable, binaries are guaranteed to only work on
platforms with the same endianness. Hence, we can rely on compile-time
cfg()checks to provide the correct host triple, despite the kernelnot providing that information.