Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the format used for build config imports on Travis CI #33

Closed
svenfuchs opened this issue Mar 16, 2020 · 4 comments
Closed

Comments

@svenfuchs
Copy link

svenfuchs commented Mar 16, 2020

rust-lang has been one of the early alpha adopters of our build config import feature.

Various repositories are still using an early format for build config sources:

owner/repo/path/to/file.yml

During the product development process this has been superseded by the format:

owner/repo:path/to/file.yml

The format has been publicly announced in Nov 2019 with the feature.

The format you are currently using is not available any more for public use, rust-lang is currently safelisted for this outdated format, so your imports continue to work. However, in future versions of the build config processing component will not be able to support this.

Please update .travis.yml files that are importing config sources using the outdated format to use the new format:

Pretty sure I'm missing other places ...

Also mentioned on:

Btw, if you are importing a single config source only then you can specify it as a string (as opposed to a sequence of strings)

import: rust-lang/simpleinfra:travis-configs/static-websites.yml

The sequence you have will work just fine of course, too:

import: 
- rust-lang/simpleinfra:travis-configs/static-websites.yml
@pietroalbini
Copy link
Member

Thanks for reporting this!

I'll go over the repositories in the next few days to migrate everything to the new syntax.

@svenfuchs
Copy link
Author

svenfuchs commented Mar 18, 2020

just to be sure ... the format for referencing a file in a foreign repo is:

owner/repo:path/to/file.yml

i am seeing something trying to reference:

rust-lang/rust-forge:rust-lang/simpleinfra/travis-configs/static-websites.yml

which i believe probably should be:

rust-lang/simpleinfra:travis-configs/static-websites.yml

@pietroalbini
Copy link
Member

I believe we updated all the users of the shared snippets in our organization, so let's close this. Thanks for the report!

By the way, I haven't found the repository with the configuration you mentioned in #33 (comment). Do you have the name of the repository on hand?

@svenfuchs
Copy link
Author

@pietroalbini ah, sorry, i have missed your last comment. no, i do not have that repo available any more. i suppose it may have been coming from a fork, or something trying things out.

i'll keep an eye out and notify them myself (or get back here) if i spot it again.

thanks a lot for taking care of this!

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants