Refactor part 4 #124
Merged
Refactor part 4 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the URLs to the repo's new home: https://github.com/rust-lang/socket2-rs. Add keywords, categories and documentation link.
It's only available on Apple platforms.
Sets the WSA_FLAG_NO_HANDLE_INHERIT flag on socket creation on Windows.
|
Main benefit is add |
|
It would be nice to get a resolution on #117 before breaking it again :( |
This was referenced Nov 9, 2020
Closed
de-vri-es
reviewed
Nov 10, 2020
To match Socket::set_nonblocking. Also add a test for it.
Matching the API of Socket::set_nonblocking.
To match Socket::set_cloexec. Also add a test for it and Type::no_inherit.
Thomasdezeeuw
force-pushed
the
refactor-p4
branch
from
ed494d5
to
878e6b4
Compare
Same as Socket::set_nonblocking. Also add test for it.
|
@de-vri-es I've address your comments and added some tests (although more will be added in the future). |
de-vri-es
approved these changes
Nov 11, 2020
|
Looks good. I'd still go with I'll start on rebasing #117 and implementing the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easiest to review by commit, those are small self-contained changes.