[illumos] enable guess_os_stack_limit #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, there are a number of CI failures but I don't think any of them are related to this change. |
This was referenced Jul 31, 2024
|
Yeah, the failures are usually unrelated -- the pace of this code is low enough that ecosystem changes break our CI pretty much every time a PR is submitted. |
Uses the same logic as FreeBSD and DragonflyBSD. This does require a version of libc with rust-lang/libc#3788 included. Hopefully that goes out soon. For now I'm putting up this PR as a thing to point to. I've verified locally on an illumos machine that stacker is able to: * find the right stack size, and * create new stack segments.
|
All right, libc 0.2.156 is out so this is now ready. |
|
Thanks! |
|
I'll cut a release shortly (after I hack on the CI stuff,) do note that you'll need to submit a PR to rustc that updates the dependency after as well, as those don't get updated automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the same logic as FreeBSD and DragonflyBSD.
Requires the latest version of libc, which has rust-lang/libc#3788 included.
I've verified locally on an illumos machine that stacker is able to: