Skip to content

Conversation

jasonwilliams
Copy link

As above, would love a code review @dten @andrii-zymohliad @Ostrovski

Copy link

@azymohliad azymohliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!
UPD: I think it would be more correct to replace "syntax highlighting" to "syntax checking" in the name of PR.

Ivan Velichko added 2 commits November 18, 2016 14:29
Since this code executes on each save I think that it have to be as optimal as possible.
Copy link

@iximiuz iximiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jayflux!
Looks good, but I've made small PRs to your fork. Please, consider to slightly reduce and simplify the code.

@jasonwilliams jasonwilliams changed the title adding ability to toggle rust syntax highlighting from command panel Fixes #121 adding ability to toggle rust syntax checking from command panel Fixes #121 Nov 18, 2016
@jasonwilliams jasonwilliams merged commit fb8fa9e into rust-lang:master Nov 18, 2016
urschrei pushed a commit to urschrei/sublime-rust that referenced this pull request Jan 30, 2018
…rust-lang#121 (rust-lang#122)

* adding ability to toggle rust syntax highlighting from command panel

* adding editorConfig

* Simplify toggling code

* Remove redundant checks

Since this code executes on each save I think that it have to be as optimal as possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants