Updating snippets #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone here ? |
|
Asked the same thing the other day :( |
|
Ok, probably no user of sublime in the rust core team :'( |
|
The last couple of times @brson merged PRs. |
|
@brson what do you think about this pull request ? |
|
Sorry @gbersac. Thanks for pinging me. PRs to these smaller rust-lang repos are easy to miss. |
|
Good additions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
// add code herecomments by unimplemented macros. It make sure the snippet can compile right after being expanded.Adding the
#[derive(Debug)]to struct and enum is, I think, a good idea because it is recommanded that every struct implement this trait because it help for debugging. Bonus : it also inform every users that the derive annotation exist.