Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for adding labels based on files changed #1321

Merged
merged 1 commit into from
Dec 12, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Apr 23, 2021

Add support for adding labels based on files changed:

[autolabel."A-rustdoc"]
# preexisting:
trigger_labels = []
exclude_labels = []
# new:
trigger_files = [
    "src/librustdoc",
    "src/tools/rustdoc",
    "src/rustdoc-json-types",
]

@jyn514
Copy link
Member Author

jyn514 commented May 24, 2021

@Mark-Simulacrum is this waiting on me? I don't know how to write tests for this.

src/handlers/autolabel.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum force-pushed the trigger-files branch 5 times, most recently from 1bcaad5 to 1355b62 Compare December 12, 2021 00:28
@Mark-Simulacrum Mark-Simulacrum changed the title [WIP] Add support for adding labels based on files changed Add support for adding labels based on files changed Dec 12, 2021
```toml
[autolabel."A-rustdoc"]
preexisting:
trigger_labels = [ ... ]
exclude_labels = [ ... ]

new:
trigger_files = [
    "src/librustdoc",
    "src/tools/rustdoc",
    "src/rustdoc-json-types",
]
```

Co-authored-by: Joshua Nelson <jyn514@gmail.com>
@Mark-Simulacrum Mark-Simulacrum merged commit 4d7456f into rust-lang:master Dec 12, 2021
camelid added a commit to rust-lang/rust that referenced this pull request Dec 12, 2021
This commit adds autolabeling for the `T-rustdoc` label, for PRs that
modify rustdoc's source code, tests, or internal tooling.

This is possible now that rust-lang/triagebot#1321 has landed.
camelid added a commit to rust-lang/rust that referenced this pull request Dec 12, 2021
This commit adds autolabeling for the `T-compiler` label, for PRs that
modify rustc's source code or tests (currently only `src/test/ui`).

This is possible now that rust-lang/triagebot#1321 has landed.
@jyn514 jyn514 deleted the trigger-files branch December 12, 2021 04:47
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2021
…-Simulacrum

rustbot: Add autolabeling for `T-rustdoc`

This commit adds autolabeling for the `T-rustdoc` label, for PRs that
modify rustdoc's source code, tests, or internal tooling.

This is possible now that rust-lang/triagebot#1321 has landed.
camelid added a commit to rust-lang/rust that referenced this pull request Dec 12, 2021
This commit adds autolabeling for the `T-compiler` label, for PRs that
modify rustc's source code or tests (currently only `src/test/ui`).

This is possible now that rust-lang/triagebot#1321 has landed.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2021
…kh726

rustbot: Add autolabeling for `T-compiler`

This commit adds autolabeling for the `T-compiler` label, for PRs that
modify rustc's source code or tests (currently only `src/test/ui`).

This is possible now that rust-lang/triagebot#1321 has landed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants