Convert Community page to Tachyons and make it Responsive. #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Decrease the specificity of the list styles in `app.scss`. - Update the community page list of RustBridge images to use a list instead of a bunch of nested `div`s.
Use an equivalent Tachyons declaration to the base `container` declaration from Skeleton. This is var more verbose, but allows setting individual properties more specifically later (rather than having to use overrides).
ashleygwilliams
approved these changes
Nov 21, 2018
delete-merged-branch
bot
deleted the
responsive-tachyons-community-233
branch
This was referenced Nov 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imgnot backgrounds. #360)Notes:
This supersedes fix(accessibility): render images with
imgnot backgrounds. #360, as I ended up just starting this on top of that branch because I needed that as the starting point for working on this page (and didn't want to lose the work I'd already done there).This includes replacing
containerwith equivalent Tachyons CSS everywhere. We likely want to revisit how that style is applied, as it's otherwise going to be a copy-paste thing everywhere. However, it's now one less piece using Skeleton, and it's also actually quite useful to build this way, given how it lets us do things like I did here and enlarging the first major section's text to have better typographical rhythm.small phone
tablet (landscape)
tablet (portrait)
laptop
widescreen