Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend cleanup: Remove Skeleton #780

Open
skade opened this issue May 20, 2019 · 17 comments

Comments

Projects
None yet
8 participants
@skade
Copy link
Collaborator

commented May 20, 2019

Supersedes #183

The Rust website currently uses two CSS frameworks: Skeleton and Tachyons (http://tachyons.io/docs/layout/flexbox/). This is due to an unfinished migration. This unfinished migration is a blocker for further extensions of the website.

We'd like to completely move over to Tachyons. There's two wishes here:

It's easy to help out! Here are some instructions:

  • Check out the website
  • Pick one of the subpages
  • Post here that you care for that subpage. You will have 7 days to post a PR (otherwise, we'll ping you)
  • (optional) join https://discord.gg/rust-lang and go to #website if you need help or feedback.
  • remove skeletons from the page: https://github.com/rust-lang/www.rust-lang.org/pull/774/files
  • Fix what's broken, using Tachyons or custom CSS. Also try to thoroughly remove now unused CSS classes.
  • Optional: check this bugtracker for issues concerning you page and try to fix them on the go

Handy page list for everyone to check:

URL Page Name Assigned Fixed
/ Index @dzhibas yes
/install Install @andirotter yes
/learn Learn @Pjb518 yes
/tools Tools @dzhibas yes
/governance Governance @dzhibas yes
/community Community @yayoc yes
/what What @skade yes
/what/cli CLI @skade
/what/embedded Embedded @skade
/what/wasm WASM @skade
/what/networking Server @dzhibas yes
/what/production Production @dzhibas yes
/policies Policies @chriskrycho yes
/policies/media-guide Media Guide @chriskrycho yes
/policies/security Security @chriskrycho yes
/policies/license License @chriskrycho yes
/policies/code-of-conduct Code of Conduct @chriskrycho yes
@andirotter

This comment has been minimized.

Copy link

commented May 20, 2019

Hey there,

i will start with the "Install" subpage. Also heading over to the discord chat for questions that might arose.

@Pjb518

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

Hey,

I've actually almost completed the Learn page. This includes a lot of site-wide styles, such as the headers and the footer code.

@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

Thanks! @Pjb518 and @andirotter!

@wizofe

This comment has been minimized.

Copy link

commented May 20, 2019

I can get the what/embedded page :)

@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 20, 2019

@wizofe go ahead. Note that @Pjb518 got header and footer ported, no need to invest time there!

@eatrero

This comment has been minimized.

Copy link

commented May 20, 2019

Hi, I can help out on the /policies page Already done #362

@Pjb518

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

@wizofe go ahead. Note that @Pjb518 got header and footer ported, no need to invest time there!

The section headings and global font size has also already been taken care of, so most of the changes now should be layout issues.

@yayoc

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

Hi, I can get /community page.

@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@yayoc yay! 🎉

dzhibas pushed a commit to dzhibas/www.rust-lang.org that referenced this issue May 21, 2019

@dzhibas

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

/tools PR #787

@skade i don't see /contribute route available

dzhibas pushed a commit to dzhibas/www.rust-lang.org that referenced this issue May 21, 2019

@dzhibas

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

404 NotFound template fix #788

after 404 and tools i ran this ripgrep through templates

$ cd templates && rg "columns" -l

production/index.hbs
components/panels/production.hbs
components/what/wasm/production.hbs
components/what/wasm/pitch.hbs
components/what/wasm/js.hbs
components/what/wasm/get-started.hbs
components/what/embedded/testimonials.hbs
components/what/embedded/showcase.hbs
components/what/cli/production.hbs
components/what/cli/example.hbs
components/what/networking/pitch.hbs
components/what/networking/production.hbs
components/what/networking/get-started.hbs
@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

@dzhibas Indeed, the /contribute page doesn't exist anymore (I thought I caught all of them when I copied the list)

skade added a commit that referenced this issue May 21, 2019

skade added a commit that referenced this issue May 21, 2019

Merge pull request #787 from dzhibas/780-get-rid-of-skeleton
#780 get rid of grid, moving to tachyons flex for /tools
@lwshang

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

I suggest to have some extra columns in the table which show the current status (like Open, In Development, Done) of a page and maybe who contributed to or is working on that page. That will make it easy to track the progress.

@dzhibas

This comment has been minimized.

Copy link
Contributor

commented May 24, 2019

totally agree @lwshang , at this point it's hard to track whats left and where people can jump in and still contribute

@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 24, 2019

I changed the list above. Anything more complex would probably need breaking things up into tickets.

@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 25, 2019

Opened PRs for the last pages, we should be able to remove skeletons over this weekend \o/.

There's a few outstanding issues, but they were there before.

@eignnx eignnx referenced this issue May 27, 2019

Closed

[meta] Add localization strings everywhere #798

7 of 7 tasks complete

@skade skade modified the milestone: Cleanup May 29, 2019

@skade

This comment has been minimized.

Copy link
Collaborator Author

commented May 31, 2019

I posted a final PR here: #833. Thanks @dzhibas @yayoc @Pjb518 @wizofe @eatrero @andirotter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.