Removes Skeleton from the Learn page and replaces the flex implementa… #781
Conversation
…tion in the footer with Tachyon styles. Adds custom CSS code which affect the global font size, as well as letter spacing and font weight for the section and page headings sitewide.
skade
requested review from
yoshuawuyts and
skade
and removed request for
yoshuawuyts
|
Thanks for the patch! There's two tiny issues on 1024x768
The horizontal lines and the buttons are not aligned.
The buttons and the text are not aligned here. |
|
Looks like the alignment issue exists in Chrome as well, and is also present in the current live site. Firefox Live site: Chrome Live site: I'll submit a fix shortly. |
…t issues with misaligned buttons in the get started with rust section. Adds several new Tachyons classes to fix alignment issues between links and labels in the Grow with Rust section.
…r match the original layout. Adds some temporary classes to prevent Skeleton classes interfering with Tachyon only styles due to shared class names.
|
@Pjb518 This looks quite good now. Am I overlooking anything or is this ready to merge? |
|
An existing inconsistency of that page is the padding the first and last columns have. Screenshot
In all the other Tachyons pages that extra margin is not present. This is also visible in any other page's footer: Screenshot
|
|
Merging this to allow people to depend on the header and footer fixes. Outstanding issues tracked as #786 |
…tion in the footer with Tachyon styles. Adds custom CSS code which affect the global font size, as well as letter spacing and font weight for the section and page headings sitewide.
Pertains to this issue: #780