Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type constraint for paths and IntoUtf8 trait #233

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Type constraint for paths and IntoUtf8 trait #233

merged 2 commits into from
Sep 4, 2023

Conversation

nitkach
Copy link
Contributor

@nitkach nitkach commented Sep 1, 2023

UTF-8 encoding trait IntoUtf8

Trait supports conversion Vec<u8> -> String and PathBuf -> Utf8PathBuf.

Utf8Path

Changing the path type to Utf8Path and Utf8PathBuf ensures that they have only UTF-8 encoding.
And also, they implement Display, which is also very convenient :)

Veetaha
Veetaha approved these changes Sep 2, 2023
View reviewed changes
cargo-marker/Cargo.toml Outdated Show resolved Hide resolved
cargo-marker/src/backend/toolchain.rs Outdated Show resolved Hide resolved
marker_rustc_driver/src/main.rs Outdated Show resolved Hide resolved
@xFrednet xFrednet self-assigned this Sep 2, 2023
@xFrednet xFrednet added this to the v0.3.0 milestone Sep 2, 2023
@xFrednet xFrednet added C-enhancement Category: New feature or request A-marker-cargo Area: All things connected to `cargo_marker` S-waiting-on-review Status: Awaiting review labels Sep 2, 2023
xFrednet
xFrednet approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version looks good to me, thank you for all the changes and the addition of snapshot tests :D

Also thank you, @Veetaha, for the review ❤️

@xFrednet xFrednet added this pull request to the merge queue Sep 4, 2023
Merged via the queue into rust-marker:master with commit 4ec73a6 Sep 4, 2023
14 checks passed
@xFrednet xFrednet mentioned this pull request Sep 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veetaha Veetaha Veetaha approved these changes

@xFrednet xFrednet xFrednet approved these changes

Assignees

@xFrednet xFrednet

Labels
A-marker-cargo Area: All things connected to `cargo_marker` C-enhancement Category: New feature or request S-waiting-on-review Status: Awaiting review
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nitkach @xFrednet @Veetaha