Param support. #30
Merged
Param support. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why checks failed in windows... |
|
It looks like large parameter can cause stack overflow. |
|
Sorry there was a bug that cannot be solved right now. |
|
Sorry again, I solved the bug that I used |
This was referenced Sep 6, 2021
Merged
|
Thanks a lot, and sorry for later reply. I've create another pull request #35 to test if these are compatible to original SFMT implementation. While testing, I found a little number of parameters are different from the original d00fcf0 . I guess it is a bug, and fixed them. Please let me known if you use these values intentionally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add other parameters algorithm support.
This breaks change to require rustc 1.51.
I also updated the rand_core version.