Skip to content

Conversation

hashemix
Copy link
Member

@hashemix hashemix commented Oct 4, 2025

📌 Summary

Previously, our glob pattern implementation only supported Unix shell–style patterns such as *, ?, **, and character classes like [a-z]. However, it did not support brace expansions (e.g., .{ts,java}), which limited pattern expressiveness for users.

This change adds support for brace expansion, allowing glob patterns like:

src/{main,test}.rs → matches src/main.rs and src/test.rs

images/{.jpg,.png} → matches all .jpg and .png files in images/

Nested braces like {a,{b,c}} are also supported (to the extent of the underlying glob implementation)

This enhancement improves compatibility with more expressive glob patterns and aligns our behavior with broader glob syntax expectations.

🔍 Related Issues

🛠️ Testing Steps

cargo make check

@hashemix hashemix merged commit 5be0b32 into main Oct 4, 2025
9 checks passed
@hashemix hashemix mentioned this pull request Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search_files does not match brace-expanded patterns like **/*.{java,ts} (returns “No matches found”), while single-extension patterns work
1 participant