Remove appx DBSCAN impl and replace with type aliases #298
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #298 +/- ##
==========================================
- Coverage 38.81% 37.14% -1.68%
==========================================
Files 94 94
Lines 6219 6200 -19
==========================================
- Hits 2414 2303 -111
- Misses 3805 3897 +92 see 11 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@quietlychris Is this fine with you? |
There was a problem hiding this comment.
Just took a look (apologies for the delay!); this all seems good to me, and I think that leaving things as a placeholder is fine.
I also looked at the partitions crate; it definitely does seem abandoned, and as far as I can tell, the maintainer (Daniel Otten) does not have any active online presence. It seems we'd probably need to fork and update partitions in the future if we wanted to use it again; I'd need to look into the standard convention in the Rust community for handling something like that, but it is an option if you'd like to go that route in the future.
|
Approx DBSCAN has been slower than DBSCAN for a long time. If there's no replacement for |
Addresses #295
Approx DBSCAN was slower than normal DBSCAN and also brings in
partitions, which is an unmaintained crate that will not compile in a future version. Since there's not easy replacement forpartitions, I decided to temporarily remove the Approx DBSCAN implementation and replace the public API with equivalent type aliases. The files for Approx DBSCAN have been kept behind in case we want to restore the implementation.