adb: Drop -W (wait for app) from am start for faster --uid filter
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This effectively reverts commit bf478ad (#118) without touching code improvements elsewhere. `-W` makes app start-up significantly slower, sometimes leaving the user wait up to 10 seconds even if the app has already started and crashed without showing any `logcat` output. It has now become unnecessary since using the app `uid` as filter in #131, which is always available as long as the app is installed and doesn't rely on a running (**before** having crashed!) executable for a process id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts commit bf478ad (#118) without touching code improvements elsewhere.
-Wmakes app start-up significantly slower, sometimes leaving the user wait up to 10 seconds even if the app has already started and crashed without showing anylogcatoutput. It has now become unnecessary since using the appuidas filter in #131, which is always available as long as the app is installed and doesn't rely on a running (before having crashed!) executable for a process id.