Introduce ArrayBase and provide both Array, OwnedArray, ArrayView and ArrayViewMut #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does not apply to the Rc version, but the owned array and views are send & sync
Less trait mess visible in the docs & simpler code
Not a problem, I'm glad if my PR helped a bit in the process. |
bluss
added a commit
that referenced
this pull request
Dec 15, 2015
Introduce ArrayBase and provide both Array, OwnedArray, ArrayView and ArrayViewMut
jturner314
pushed a commit
to jturner314/ndarray
that referenced
this pull request
Jun 19, 2019
Update master
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @vbarrielle I regret to inform you it's very similar to your PR #3.
In this PR, I don't rename the Array type etc, so my projects using ndarray continue to compile. Most client code should, there might be some type inference related changes needed.
Fixes #7