Implement Euclid division and remainder #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
requested changes
Feb 11, 2023
|
Thanks for the review! I've added commits based on the above requested changes, and the branch is now ready for another review. |
|
I rebased this and added a couple compat fixes. Otherwise, looks good, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 22, 2023
245: Implement Euclid division and remainder r=cuviper a=jaybosamiya Now that a common trait for this has been sorted out (rust-num/num-traits#159 implemented and merged in rust-num/num-traits#195), we can now close #146 by implementing the trait for `BigInt`s. This commit does just that. Co-authored-by: Jay Bosamiya <jaybosamiya@gmail.com> Co-authored-by: Josh Stone <cuviper@gmail.com>
|
Build failed: |
|
bors retry |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
Thanks for rebasing and merging! |
jaybosamiya
added a commit
to verus-lang/verus
that referenced
this pull request
Aug 23, 2023
Now that rust-num/num-bigint#245 has been merged, by updating the version of num-bigint used in Verus, we get to remove our custom implementation of these two functions.
jaybosamiya
added a commit
to verus-lang/verus
that referenced
this pull request
Aug 25, 2023
Now that rust-num/num-bigint#245 has been merged, by updating the version of num-bigint used in Verus, we get to remove our custom implementation of these two functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that a common trait for this has been sorted out (rust-num/num-traits#159 implemented and merged in rust-num/num-traits#195), we can now close #146 by implementing the trait for
BigInts. This commit does just that.