Make Shr for negative BigInt round down, like primitives do #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2018
Primitive integers always round down when shifting right, but `BigInt` was effectively rounding toward zero, because it just kept its sign and used the `BigUint` magnitude rounded down (always toward zero). Now we adjust the result of shifting negative values, and explicitly test that it matches the result for primitive integers.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 24, 2018
8: Make Shr for negative BigInt round down, like primitives do r=cuviper a=cuviper Primitive integers always round down when shifting right, but `BigInt` was effectively rounding toward zero, because it just kept its sign and used the `BigUint` magnitude rounded down (always toward zero). Now we adjust the result of shifting negative values, and explicitly test that it matches the result for primitive integers. Fixes #1.
Build succeeded |
dingelish
pushed a commit
to mesalock-linux/num-bigint-sgx
that referenced
this pull request
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitive integers always round down when shifting right, but
BigIntwas effectively rounding toward zero, because it just kept its sign and
used the
BigUintmagnitude rounded down (always toward zero).Now we adjust the result of shifting negative values, and explicitly
test that it matches the result for primitive integers.
Fixes #1.