-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement std::iter::{Sum, Product} #11
Conversation
I met this error with 1.12.0. I will use 1.14.0 like #7 |
Thanks - I'll need to hold this PR until I'm ready to make breaking changes. |
I see the num-complex 0.2 milestone, where these two issues are listed. Is there another issue to be included in num-complex 0.2 ? |
Maybe also #6 for |
I guess the |
I'd rather work it out and bump only once in a long while. |
Folding can be faster for some iterators, and this way we also don't need to require `NumAssign`.
Rebased, then I made it use folds instead. Thanks for the PR! bors r+ |
11: Implement std::iter::{Sum, Product} r=cuviper a=termoshtt Resolve #3 - Implement `Sum<Complex<T>>` and `Sum<&Complex<T>>` using `Zero` + `AddAssign` - Implement `Product<Complex<T>>` and `Product<&Complex<T>>` using `One` + `MulAssign` `Num` and `NumAssign` are used for type constraint.
Build succeeded |
Resolve #3
Sum<Complex<T>>
andSum<&Complex<T>>
usingZero
+AddAssign
Product<Complex<T>>
andProduct<&Complex<T>>
usingOne
+MulAssign
Num
andNumAssign
are used for type constraint.