Use values for all Float methods #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `T: Float` also implies `T: Copy`, we don't need the indirection of a reference for `self` or other parameters. Most of these are marked `#[inline]` anyway, so in the end the change won't make much difference to optimization, but it's semantically cleaner. Users probably won't notice the change in method calls from `&self` to `self`, but construction `from_polar` will need adjustment.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
T: Floatalso impliesT: Copy, we don't need the indirectionof a reference for
selfor other parameters. Most of these are marked#[inline]anyway, so in the end the change won't make much differenceto optimization, but it's semantically cleaner.
Users probably won't notice the change in method calls from
&selftoself, but constructionfrom_polarwill need adjustment.Fixes #80.