-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to syn-2 #54
Update to syn-2 #54
Conversation
Do we use anything that would need "full" anymore? If not, I think we should just drop that feature. We can bump semver for the new MSRV requirement while we're at it, so a breaking feature change is ok. |
Also moves a test out of doctest compilefail since syn-2 will build it correctly even without the "full" feature.
The primary use-case of full-syntax (complex discriminants) is now covered by syn even without full, so this feature is unnecessary. Since bumping the MSRV for syn to 1.56 is a breaking change, we can drop the full-syntax feature at the same time.
I fixed up the |
@cuviper is there anything holding this up? |
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Lack of time and attention... but it's published now! |
Also moves a test out of doctest compilefail since syn-2 will build it correctly even without the "full" feature.