Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lcm(0, 0) = 0 #18

Merged
merged 2 commits into from
Jan 26, 2019
Merged

lcm(0, 0) = 0 #18

merged 2 commits into from
Jan 26, 2019

Conversation

strake
Copy link
Contributor

@strake strake commented Dec 18, 2018

No description provided.

@strake strake mentioned this pull request Dec 18, 2018
Merged
cuviper
cuviper reviewed Jan 26, 2019
View reviewed changes
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is good, but please use standard formatting for the if-else blocks.

@cuviper
Copy link
Member

cuviper commented Jan 26, 2019

Actually, I missed this whole crate when I formatted num before. I'll do it.

@cuviper
Run cargo fmt
8307b96 
... with tweaks to signed div/mod_floor for better formatting.
@cuviper
Copy link
Member

cuviper commented Jan 26, 2019

bors r+

bors bot added a commit that referenced this pull request Jan 26, 2019
@bors @strake @cuviper
Merge #18
f2423e9 
18: lcm(0, 0) = 0 r=cuviper a=strake



Co-authored-by: M Farkas-Dyck <strake888@gmail.com>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2019

Build succeeded

@bors bors bot merged commit 8307b96 into rust-num:master Jan 26, 2019
@strake strake deleted the lcm branch March 21, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuviper cuviper cuviper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strake @cuviper